From: Michal Wilczynski <m.wilczynski@samsung.com>
To: "Kari Argillander" <kari.argillander@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] rust: pwm: Simplify to_result call sites and unsafe blocks
Date: Mon, 5 Jan 2026 12:12:37 +0100 [thread overview]
Message-ID: <9f45c967-4bb0-4b42-9d5f-6bd338eba0db@samsung.com> (raw)
In-Reply-To: <20260102-pwm-rust-v2-2-2702ce57d571@gmail.com>
On 1/2/26 08:51, Kari Argillander wrote:
> Remove unnecessary temporary variables around to_result() calls and move
> trailing semicolons outside unsafe blocks to improve readability and
> produce cleaner rustfmt output.
>
> No functional change intended.
>
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> ---
> rust/kernel/pwm.rs | 47 ++++++++++++++---------------------------------
> 1 file changed, 14 insertions(+), 33 deletions(-)
>
Hi, the changes look fine to me, they are more idiomatic to Rust.
Acked-by: Michal Wilczynski <m.wilczynski@samsung.com>
next prev parent reply other threads:[~2026-01-05 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 7:51 [PATCH v2 0/2] rust: pwm: Fix init error handling and tidy style Kari Argillander
2026-01-02 7:51 ` [PATCH v2 1/2] rust: pwm: Fix potential memory leak on init error Kari Argillander
2026-01-05 10:50 ` Michal Wilczynski
2026-01-02 7:51 ` [PATCH v2 2/2] rust: pwm: Simplify to_result call sites and unsafe blocks Kari Argillander
2026-01-05 11:12 ` Michal Wilczynski [this message]
2026-01-20 17:59 ` [PATCH v2 0/2] rust: pwm: Fix init error handling and tidy style Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f45c967-4bb0-4b42-9d5f-6bd338eba0db@samsung.com \
--to=m.wilczynski@samsung.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®