Re: [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p

[Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>]

Hi Bryan,

On 3/13/2026 5:46 PM, Bryan O'Donoghue wrote:
> On 13/03/2026 09:42, Wenmeng Liu wrote:
>> Fix two issues in csid driver for 8775p platform:
>>
>> 1. Simplify clock configuration for csid lite by removing unused clocks
>>     and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx
>>     clocks are actually needed.
> 
> This should be its own patch and should that patch have a Fixes: ?
> 
> Simplification != fixing a bug.

Sure, There is also an issue with the clock here, I will also modify the 
description.

> 
>> 2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on
>>     sa8775p platform. The offset should be 0 for csid lite on sa8775p,
>>
>> Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690")
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> 
> Yeah this should be standalone then.
> 
> My general rule here is if your patch requires line items to explain 
> various things being done, then those line-items deserve their own patch.
ACK.
> 
> ---
> bod

Thanks,
Wenmeng