* [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing
@ 2022-03-28 1:28 Kunihiko Hayashi
2022-03-28 19:04 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Kunihiko Hayashi @ 2022-03-28 1:28 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, linux-gpio, devicetree, linux-arm-kernel,
linux-kernel, Kunihiko Hayashi
Allow parsing GPIO controller children nodes with GPIO hogs to fix the
following warning:
uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
index bcafa494ed7a..b6f5963a2ae6 100644
--- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
@@ -52,6 +52,13 @@ properties:
<child-interrupt-base parent-interrupt-base length> triplets.
$ref: /schemas/types.yaml#/definitions/uint32-matrix
+patternProperties:
+ "^(.+-hog(-[0-9]+)?)$":
+ type: object
+
+ required:
+ - gpio-hog
+
required:
- compatible
- reg
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing
2022-03-28 1:28 [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing Kunihiko Hayashi
@ 2022-03-28 19:04 ` Krzysztof Kozlowski
2022-03-29 10:56 ` Kunihiko Hayashi
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-28 19:04 UTC (permalink / raw)
To: Kunihiko Hayashi, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, linux-gpio, devicetree, linux-arm-kernel, linux-kernel
On 28/03/2022 03:28, Kunihiko Hayashi wrote:
> Allow parsing GPIO controller children nodes with GPIO hogs to fix the
> following warning:
>
> uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> index bcafa494ed7a..b6f5963a2ae6 100644
> --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> @@ -52,6 +52,13 @@ properties:
> <child-interrupt-base parent-interrupt-base length> triplets.
> $ref: /schemas/types.yaml#/definitions/uint32-matrix
>
> +patternProperties:
> + "^(.+-hog(-[0-9]+)?)$":
The outer () are not needed.
> + type: object
You need also properties. See for example:
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> +
> + required:
> + - gpio-hog
> +
> required:
> - compatible
> - reg
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing
2022-03-28 19:04 ` Krzysztof Kozlowski
@ 2022-03-29 10:56 ` Kunihiko Hayashi
0 siblings, 0 replies; 3+ messages in thread
From: Kunihiko Hayashi @ 2022-03-29 10:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, linux-gpio, devicetree, linux-arm-kernel, linux-kernel
Hi Krzysztof,
On 2022/03/29 4:04, Krzysztof Kozlowski wrote:
> On 28/03/2022 03:28, Kunihiko Hayashi wrote:
>> Allow parsing GPIO controller children nodes with GPIO hogs to fix the
>> following warning:
>>
>> uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of
>> the regexes: 'pinctrl-[0-9]+'
>> From schema:
>> Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> index bcafa494ed7a..b6f5963a2ae6 100644
>> --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> @@ -52,6 +52,13 @@ properties:
>> <child-interrupt-base parent-interrupt-base length> triplets.
>> $ref: /schemas/types.yaml#/definitions/uint32-matrix
>>
>> +patternProperties:
>> + "^(.+-hog(-[0-9]+)?)$":
>
> The outer () are not needed.
Surely, the "()" can be removed.
>> + type: object
>
> You need also properties. See for example:
> Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
I see. I should list the valid properties in patternProperties.
I'll add it.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-29 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 1:28 [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing Kunihiko Hayashi
2022-03-28 19:04 ` Krzysztof Kozlowski
2022-03-29 10:56 ` Kunihiko Hayashi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®