From: "Cyril Chao (钞悦)" <Cyril.Chao@mediatek.com>
To: "krzk@kernel.org" <krzk@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"robh@kernel.org" <robh@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"perex@perex.cz" <perex@perex.cz>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 10/10] ASoC: dt-bindings: mediatek,mt8189-nau8825: add mt8189-nau8825 document
Date: Fri, 18 Jul 2025 08:48:16 +0000 [thread overview]
Message-ID: <9f752338a2deda3e3475468ccc881230dc370f88.camel@mediatek.com> (raw)
In-Reply-To: <43b4c2bb-a1ed-4f6d-9977-512617130337@kernel.org>
On Sat, 2025-06-28 at 14:42 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 28/06/2025 09:14, Cyril wrote:
> > From: Cyril Chao <Cyril.Chao@mediatek.com>
> >
> > Add document for mt8189 board with nau8825.
> >
> > Signed-off-by: Cyril Chao <Cyril.Chao@mediatek.com>
>
> Why does the binding come after user? Follow submitting patches in
> DT.
>
Could you help to clarify this? Is it the order in which I submitted
the dt-binding patch that's incorrect? Much thanks~~
> > ---
> > .../sound/mediatek,mt8189-nau8825.yaml | 103
> > ++++++++++++++++++
> > 1 file changed, 103 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > b/Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > new file mode 100644
> > index 000000000..331c537d3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt8189-nau8825.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BLVZS00w$
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BzAjmYYE$
> > +
> > +title: MediaTek MT8189 ASoC sound card
> > +
> > +maintainers:
> > + - Darren Ye <darren.ye@mediatek.com>
> > + - Cyril Chao <cyril.chao@mediatek.com>
> > +
> > +allOf:
> > + - $ref: sound-card-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8189-nau8825-sound
> > + - mediatek,mt8189-rt5650-sound
> > + - mediatek,mt8189-rt5682s-sound
> > + - mediatek,mt8189-rt5682i-sound
>
> Sound is redundant. Can it be anything else?
>
Okay, I will remove 'sound' next version, and like this:
mediatek,mt8189-nau8825
mediatek,mt8189-rt5650
mediatek,mt8189-rt5682s
mediatek,mt8189-rt5682i
Thanks for review~~~
Best Regards
Cyril Chao
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-07-18 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 7:14 [PATCH 00/10] ASoC: mediatek: Add support for MT8189 SoC Cyril
2025-06-28 7:14 ` [PATCH 01/10] ASoC: mediatek: mt8189: add common header Cyril
2025-06-28 7:14 ` [PATCH 02/10] ASoC: mediatek: mt8189: support audio clock control Cyril
2025-06-28 7:14 ` [PATCH 03/10] ASoC: mediatek: mt8189: support ADDA in platform driver Cyril
2025-06-28 7:14 ` [PATCH 04/10] ASoC: mediatek: mt8189: support I2S " Cyril
2025-06-28 7:14 ` [PATCH 05/10] ASoC: mediatek: mt8189: support TDM " Cyril
2025-06-28 7:14 ` [PATCH 06/10] ASoC: mediatek: mt8189: support PCM " Cyril
2025-06-28 7:14 ` [PATCH 07/10] ASoC: mediatek: mt8189: add " Cyril
2025-06-28 7:14 ` [PATCH 08/10] ASoC: dt-bindings: mediatek,mt8189-afe-pcm: add audio afe document Cyril
2025-06-28 12:46 ` Krzysztof Kozlowski
2025-06-28 7:14 ` [PATCH 09/10] ASoC: mediatek: mt8189: add machine driver with nau8825 Cyril
2025-06-28 12:39 ` Krzysztof Kozlowski
2025-07-18 8:44 ` Cyril Chao (钞悦)
2025-07-18 9:18 ` Krzysztof Kozlowski
2025-06-28 7:14 ` [PATCH 10/10] ASoC: dt-bindings: mediatek,mt8189-nau8825: add mt8189-nau8825 document Cyril
2025-06-28 12:42 ` Krzysztof Kozlowski
2025-07-18 8:48 ` Cyril Chao (钞悦) [this message]
2025-07-18 9:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f752338a2deda3e3475468ccc881230dc370f88.camel@mediatek.com \
--to=cyril.chao@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®