Re: [PATCH 09/10] ASoC: mediatek: mt8189: add machine driver with nau8825

[Krzysztof Kozlowski <krzk@kernel.org>]

On 18/07/2025 10:44, Cyril Chao (钞悦) wrote:
> On Sat, 2025-06-28 at 14:39 +0200, Krzysztof Kozlowski wrote:
>>> +             .of_match_table = mt8189_nau8825_dt_match,
>>> +#endif
>>> +             .pm = &snd_soc_pm_ops,
>>> +     },
>>> +     .probe = mtk_soundcard_common_probe,
>>> +};
>>> +
>>> +module_platform_driver(mt8189_nau8825_driver);
>>> +
>>> +/* Module information */
>>> +MODULE_DESCRIPTION("MT8189 NAU8825 ALSA SoC machine driver");
>>> +MODULE_AUTHOR("Darren Ye <darren.ye@mediatek.com>");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("mt8189 nau8825 soc card");
>>
>> That's neither needed nor correct. Look how aliases are created
>> first.
> 
> I reffered to the previous platform(mt8188). Could you help to give an
> example about MODULE_ALIAS or some doc for me to reffer? Much thanks ~~

If you ask for doc, then it feels like you do not know if you need it. I
think you do not need it and the burden of proving why you need it is on
you.

Best regards,
Krzysztof