Re: [PATCH v1 1/2] phy: qcom: qmp-combo: Add PM suspend/resume callbacks

[Prashanth K <prashanth.k@oss.qualcomm.com>]

On 10/30/2026 6:54 PM, Konrad Dybcio wrote:
> On 10/29/26 7:11 AM, Prashanth K wrote:
>>
>>
>> On 10/23/2026 3:53 PM, Konrad Dybcio wrote:
>>> On 10/22/26 12:43 PM, Prashanth K wrote:
>>>> Currently when we perform system suspend, the phy clocks aren't
>>>> turned off leading to power leakage. Prevent this by adding PM
>>>> suspend/resume callbacks for the qmp-combo-phy which toggles
>>>> clocks on/off correspondingly.
>>>>
>>>> Signed-off-by: Prashanth K <prashanth.k@oss.qualcomm.com>
>>>> ---
>>>
>>> Well this still leaves pm_runtime_forbid() in the probe function..
>>>
>>
>> Not sure about the history behind this, I assume its for controlling RT
>> behavior from user-space.
> 
> Long story short it was an opt-in because it was broken.. can't recall
> if the issues were on the dwc3-qcom(-legacy) side or somewhere in the
> PHY code itself.
> 
> Konrad

ok, I'm not sure if we should modify it in this patch, I'll enable the
RT PM operations and check its behavior. But this patch is intended to
enable the system suspend/resume ops for qmp phy.

While at it, you had suggested to add mutex guard on RT operations,
I think we can add that also as a separate series since it needs
addition of mutex on qmp-usb driver.

Regards,
Prashanth K