From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Prashanth K <prashanth.k@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] phy: qcom: qmp-combo: Add PM suspend/resume callbacks
Date: Fri, 30 Oct 2026 14:24:37 +0100 [thread overview]
Message-ID: <a05ddb1a-a84b-4db0-9806-918958f3a962@oss.qualcomm.com> (raw)
In-Reply-To: <a8104e92-990c-4e1a-aa4a-c97b9a801935@oss.qualcomm.com>
On 10/29/26 7:11 AM, Prashanth K wrote:
>
>
> On 10/23/2026 3:53 PM, Konrad Dybcio wrote:
>> On 10/22/26 12:43 PM, Prashanth K wrote:
>>> Currently when we perform system suspend, the phy clocks aren't
>>> turned off leading to power leakage. Prevent this by adding PM
>>> suspend/resume callbacks for the qmp-combo-phy which toggles
>>> clocks on/off correspondingly.
>>>
>>> Signed-off-by: Prashanth K <prashanth.k@oss.qualcomm.com>
>>> ---
>>
>> Well this still leaves pm_runtime_forbid() in the probe function..
>>
>
> Not sure about the history behind this, I assume its for controlling RT
> behavior from user-space.
Long story short it was an opt-in because it was broken.. can't recall
if the issues were on the dwc3-qcom(-legacy) side or somewhere in the
PHY code itself.
Konrad
next prev parent reply other threads:[~2026-10-30 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 10:43 [PATCH v1 0/2] Add the PM suspend/resume callbacks for qcom-combo phys Prashanth K
2026-10-22 10:43 ` [PATCH v1 1/2] phy: qcom: qmp-combo: Add PM suspend/resume callbacks Prashanth K
2026-10-23 10:23 ` Konrad Dybcio
2026-10-29 6:11 ` Prashanth K
2026-10-30 13:24 ` Konrad Dybcio [this message]
2026-11-02 8:15 ` Prashanth K
2026-11-02 14:39 ` Konrad Dybcio
2026-10-22 10:43 ` [PATCH v1 2/2] phy: qcom: qmp-usb: " Prashanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05ddb1a-a84b-4db0-9806-918958f3a962@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=prashanth.k@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®