mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng
@ 2026-10-01  5:51 Barnabás Czémán
  2026-10-01  5:51 ` [PATCH 1/3] arm64: dts: qcom: msm8917: change prng compatible Barnabás Czémán
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Barnabás Czémán @ 2026-10-01  5:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Stephan Gerhold,
	Otto Pflüger, Dang Huynh, Dmitry Baryshkov, Luca Weiss,
	Vladimir Lypak
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
	Barnabás Czémán

On MSM8917/MSM8937/MSM8953 HW QRNG is configured by TZ.
qcom-rng driver will not have access to the configuration registers.
Change the compatible to qcom,prng-ee for skip the initialization sequence.

Compatbile changes are fixing this issue:
Call trace:
 qcom_rng_init+0x6c/0xe8 [qcom_rng] (P)
 crypto_create_tfm_node+0x154/0x198
 crypto_alloc_tfm_node+0xa4/0x1b4
 crypto_alloc_rng+0x34/0x48
 rng_bind+0x60/0xa8 [algif_rng]
 alg_bind+0x15c/0x1f4 [af_alg]
 __arm64_sys_bind+0xb8/0x120
 invoke_syscall+0x6c/0x11c
 el0_svc_common+0x98/0xe8
 do_el0_svc+0x2c/0x3c
 el0_svc+0x40/0x9c
 el0t_64_sync_handler+0x88/0x134
 el0t_64_sync+0x1a0/0x1a4

Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
Barnabás Czémán (3):
      arm64: dts: qcom: msm8917: change prng compatible
      arm64: dts: qcom: msm8937: change prng compatible
      arm64: dts: qcom: msm8953: change prng compatible

 arch/arm64/boot/dts/qcom/msm8917.dtsi | 2 +-
 arch/arm64/boot/dts/qcom/msm8937.dtsi | 2 +-
 arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 6c2cb8b8b843d216ab549b678a0d8831c43153e0
change-id: 20261001-prng-fix-5366a05da970

Best regards,
--  
Barnabás Czémán <barnabas.czeman@mainlining.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] arm64: dts: qcom: msm8917: change prng compatible
  2026-10-01  5:51 [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Barnabás Czémán
@ 2026-10-01  5:51 ` Barnabás Czémán
  2026-10-01  5:51 ` [PATCH 2/3] arm64: dts: qcom: msm8937: " Barnabás Czémán
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2026-10-01  5:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Stephan Gerhold,
	Otto Pflüger, Dang Huynh, Dmitry Baryshkov, Luca Weiss,
	Vladimir Lypak
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
	Barnabás Czémán

On MSM8917 HW QRNG is configured by TZ. qcom-rng driver
will not have access to the configuration registers.
Change the compatible to qcom,prng-ee for skip the initialization sequence.

Fixes: 7f18b1ea7987 ("arm64: dts: qcom: Add initial support for MSM8917")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 arch/arm64/boot/dts/qcom/msm8917.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8917.dtsi b/arch/arm64/boot/dts/qcom/msm8917.dtsi
index a2907f8a6376..ca647efc883f 100644
--- a/arch/arm64/boot/dts/qcom/msm8917.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8917.dtsi
@@ -610,7 +610,7 @@ tsens_s10_p2: s10-p2@232 {
 		};
 
 		rng@e3000 {
-			compatible = "qcom,prng";
+			compatible = "qcom,prng-ee";
 			reg = <0x000e3000 0x1000>;
 			clocks = <&gcc GCC_PRNG_AHB_CLK>;
 			clock-names = "core";

-- 
2.56.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] arm64: dts: qcom: msm8937: change prng compatible
  2026-10-01  5:51 [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Barnabás Czémán
  2026-10-01  5:51 ` [PATCH 1/3] arm64: dts: qcom: msm8917: change prng compatible Barnabás Czémán
@ 2026-10-01  5:51 ` Barnabás Czémán
  2026-10-01  5:51 ` [PATCH 3/3] arm64: dts: qcom: msm8953: " Barnabás Czémán
  2026-10-01  9:21 ` [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Konrad Dybcio
  3 siblings, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2026-10-01  5:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Stephan Gerhold,
	Otto Pflüger, Dang Huynh, Dmitry Baryshkov, Luca Weiss,
	Vladimir Lypak
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
	Barnabás Czémán

On MSM8937 HW QRNG is configured by TZ. qcom-rng driver
will not have access to the configuration registers.
Change the compatible to qcom,prng-ee for skip the initialization sequence.

Fixes: a829f6f2e8a7 ("arm64: dts: qcom: Add initial support for MSM8937")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 arch/arm64/boot/dts/qcom/msm8937.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8937.dtsi b/arch/arm64/boot/dts/qcom/msm8937.dtsi
index 7de6447de48f..73909d6179c3 100644
--- a/arch/arm64/boot/dts/qcom/msm8937.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8937.dtsi
@@ -653,7 +653,7 @@ usb_hs_phy: phy@6c000 {
 		};
 
 		rng@e3000 {
-			compatible = "qcom,prng";
+			compatible = "qcom,prng-ee";
 			reg = <0x000e3000 0x1000>;
 			clocks = <&gcc GCC_PRNG_AHB_CLK>;
 			clock-names = "core";

-- 
2.56.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] arm64: dts: qcom: msm8953: change prng compatible
  2026-10-01  5:51 [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Barnabás Czémán
  2026-10-01  5:51 ` [PATCH 1/3] arm64: dts: qcom: msm8917: change prng compatible Barnabás Czémán
  2026-10-01  5:51 ` [PATCH 2/3] arm64: dts: qcom: msm8937: " Barnabás Czémán
@ 2026-10-01  5:51 ` Barnabás Czémán
  2026-10-01  9:21 ` [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Konrad Dybcio
  3 siblings, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2026-10-01  5:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Stephan Gerhold,
	Otto Pflüger, Dang Huynh, Dmitry Baryshkov, Luca Weiss,
	Vladimir Lypak
  Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
	Barnabás Czémán

On MSM8953 HW QRNG is configured by TZ. qcom-rng driver
will not have access to the configuration registers.
Change the compatible to qcom,prng-ee for skip the initialization sequence.

Fixes: 9fb08c801923 ("arm64: dts: qcom: Add MSM8953 device tree")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index 753167c3f861..99a1bca8e13a 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -483,7 +483,7 @@ hsusb_phy: phy@79000 {
 		};
 
 		rng@e3000 {
-			compatible = "qcom,prng";
+			compatible = "qcom,prng-ee";
 			reg = <0x000e3000 0x1000>;
 			clocks = <&gcc GCC_PRNG_AHB_CLK>;
 			clock-names = "core";

-- 
2.56.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng
  2026-10-01  5:51 [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Barnabás Czémán
                   ` (2 preceding siblings ...)
  2026-10-01  5:51 ` [PATCH 3/3] arm64: dts: qcom: msm8953: " Barnabás Czémán
@ 2026-10-01  9:21 ` Konrad Dybcio
  3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-10-01  9:21 UTC (permalink / raw)
  To: Barnabás Czémán, Bjorn Andersson, Konrad Dybcio,
	Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Stephan Gerhold, Otto Pflüger, Dang Huynh, Dmitry Baryshkov,
	Luca Weiss, Vladimir Lypak
  Cc: linux-arm-msm, devicetree, linux-kernel

On 10/1/26 7:51 AM, Barnabás Czémán wrote:
> On MSM8917/MSM8937/MSM8953 HW QRNG is configured by TZ.
> qcom-rng driver will not have access to the configuration registers.
> Change the compatible to qcom,prng-ee for skip the initialization sequence.
> 
> Compatbile changes are fixing this issue:
> Call trace:
>  qcom_rng_init+0x6c/0xe8 [qcom_rng] (P)
>  crypto_create_tfm_node+0x154/0x198
>  crypto_alloc_tfm_node+0xa4/0x1b4
>  crypto_alloc_rng+0x34/0x48
>  rng_bind+0x60/0xa8 [algif_rng]
>  alg_bind+0x15c/0x1f4 [af_alg]
>  __arm64_sys_bind+0xb8/0x120
>  invoke_syscall+0x6c/0x11c
>  el0_svc_common+0x98/0xe8
>  do_el0_svc+0x2c/0x3c
>  el0_svc+0x40/0x9c
>  el0t_64_sync_handler+0x88/0x134
>  el0t_64_sync+0x1a0/0x1a4
> 
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-01  9:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-01  5:51 [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Barnabás Czémán
2026-10-01  5:51 ` [PATCH 1/3] arm64: dts: qcom: msm8917: change prng compatible Barnabás Czémán
2026-10-01  5:51 ` [PATCH 2/3] arm64: dts: qcom: msm8937: " Barnabás Czémán
2026-10-01  5:51 ` [PATCH 3/3] arm64: dts: qcom: msm8953: " Barnabás Czémán
2026-10-01  9:21 ` [PATCH 0/3] MSM8917/MSM8937/MSM8953 fix prng Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®