mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yisheng Xie <xieyisheng1@huawei.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: <nico@linaro.org>, <catalin.marinas@arm.com>,
	<will.deacon@arm.com>, <linux-kernel@vger.kernel.org>,
	<viro@zeniv.linux.org.uk>, <wangfangpeng1@huawei.com>,
	<guohanjun@huawei.com>, <matthias.bgg@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] Revert "ARM: 8433/1: add a VMSPLIT_3G_OPT config option"
Date: Thu, 8 Jun 2017 09:23:10 +0800	[thread overview]
Message-ID: <9fbfa9c0-e46f-0f88-4c8f-de8be9114941@huawei.com> (raw)
In-Reply-To: <20170607093350.GJ4902@n2100.armlinux.org.uk>

Hi Russell,

Thanks for comment!
On 2017/6/7 17:33, Russell King - ARM Linux wrote:
> On Wed, Jun 07, 2017 at 04:59:32PM +0800, Yisheng Xie wrote:
>> This reverts commit 63ce446c9b5787a94ed875bab20772e1a2b3092f.
> 
> There's no real reason to revert this, thereby removing it from non-LPAE
> cases where it does work.  You've already shown adding a dependency for
> LPAE on this option (or even vice versa) is enough to stop the problem
> occuring.
> 
> IMHO, It would be better to make VMSPLIT_3G_OPT depend on !ARM_LPAE.

OK, I will send a patch as your suggestion.

Thanks
Yisheng Xie

      reply	other threads:[~2017-06-08  1:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  8:59 Yisheng Xie
2017-06-07  9:33 ` Russell King - ARM Linux
2017-06-08  1:23   ` Yisheng Xie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fbfa9c0-e46f-0f88-4c8f-de8be9114941@huawei.com \
    --to=xieyisheng1@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=matthias.bgg@gmail.com \
    --cc=nico@linaro.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wangfangpeng1@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®