mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Joshua Crofts" <joshua.crofts1@gmail.com>,
	"Radu Sabau" <radu.sabau@analog.com>,
	"Salih Erim" <salih.erim@amd.com>,
	"Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
	"Jakub Szczudlo" <jakubszczudlo40@gmail.com>,
	linux-iio@vger.kernel.org, linux@analog.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 0/6] iio: adc: ade9000: add ADE9430 support
Date: Fri, 18 Sep 2026 16:27:30 +0100	[thread overview]
Message-ID: <9fc012985151b1b79b5d6e3f16738397ac9f837f.camel@gmail.com> (raw)
In-Reply-To: <20260918073537.1572-1-antoniu.miclaus@analog.com>

On Fri, 2026-09-18 at 10:35 +0300, Antoniu Miclaus wrote:
> The ADE9430 is a polyphase energy metering device from the same family as
> the ADE9000. It is register-compatible with the ADE9000 but omits the
> on-chip dip/swell detection and has no on-chip digital integrator; it
> relies on an external analog integrator for Rogowski coil current sensors.
> 
> This series adds ADE9430 support to the existing ade9000 driver, reusing
> the dip/swell-less channel table introduced for the ADE9078 and adding a
> matching chip_info for the ADE9430 full-scale codes. A precursor patch
> gates the DICOEFF register write behind a has_digital_integrator chip_info
> flag so it is skipped on parts without an on-chip digital integrator.
> 
> Patches 1 and 2 are standalone fixes carried with this series. Patch 1
> corrects the ADE9000 full-scale RMS/PCF codes to the same family-A values
> the ADE9430 uses. Patch 2 fixes the DIPC event never being handled or
> cleared, found by the sashiko review of v1. Both carry Fixes: tags and can
> be applied independently of the rest of the series.
> 
> Changes in v2:
> - new patch: fix the DIPC event never being handled or cleared, found by
>   the sashiko review of v1 (patch 2).
> - new precursor patch: gate the DICOEFF write behind a has_digital_integrator
>   chip_info flag, split out of the ADE9430 support patch.
> - reuse ade9078_channels for the ADE9430 instead of adding a duplicate
>   channel table.
> - reword the documentation intro to "The supported parts are..." so it does
>   not need updating for each new part.
> 
> v1:
> https://lore.kernel.org/linux-iio/20260907101623.8730-1-antoniu.miclaus@analog.com/
> 
> Antoniu Miclaus (6):
>   iio: adc: ade9000: fix ADE9000 full-scale RMS and PCF codes
>   iio: adc: ade9000: fix DIPC event never being handled or cleared
>   dt-bindings: iio: adc: adi,ade9000: add adi,ade9430 compatible
>   iio: adc: ade9000: gate the DICOEFF write behind a chip_info flag
>   iio: adc: ade9000: add support for ADE9430
>   docs: iio: ade9000: document ADE9430 support
> 
>  .../bindings/iio/adc/adi,ade9000.yaml         | 22 ++++++-----
>  Documentation/iio/ade9000.rst                 | 36 +++++++++--------
>  drivers/iio/adc/Kconfig                       |  1 +
>  drivers/iio/adc/ade9000.c                     | 39 ++++++++++++++++---
>  4 files changed, 67 insertions(+), 31 deletions(-)
> 
> 
> base-commit: edb91bc566576f6664a3efbad6bd4205aa1d5259

LGTM

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

      parent reply	other threads:[~2026-09-18 15:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  7:35 Antoniu Miclaus
2026-09-18  7:35 ` [PATCH v2 1/6] iio: adc: ade9000: fix ADE9000 full-scale RMS and PCF codes Antoniu Miclaus
2026-09-18  7:35 ` [PATCH v2 2/6] iio: adc: ade9000: fix DIPC event never being handled or cleared Antoniu Miclaus
2026-09-18  7:35 ` [PATCH v2 3/6] dt-bindings: iio: adc: adi,ade9000: add adi,ade9430 compatible Antoniu Miclaus
2026-09-18  7:35 ` [PATCH v2 4/6] iio: adc: ade9000: gate the DICOEFF write behind a chip_info flag Antoniu Miclaus
2026-09-18  7:35 ` [PATCH v2 5/6] iio: adc: ade9000: add support for ADE9430 Antoniu Miclaus
2026-09-18  7:35 ` [PATCH v2 6/6] docs: iio: ade9000: document ADE9430 support Antoniu Miclaus
2026-09-18 15:27 ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fc012985151b1b79b5d6e3f16738397ac9f837f.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jakubszczudlo40@gmail.com \
    --cc=jic23@kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=radu.sabau@analog.com \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=salih.erim@amd.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®