* [PATCH] usb: gadget: omap_udc: fix USB gadget regression on Palm TE
@ 2024-02-17 19:20 Aaro Koskinen
2024-02-17 20:01 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2024-02-17 19:20 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arnd Bergmann, linux-usb
Cc: Aaro Koskinen, linux-kernel, linux-omap
When upgrading from 6.1 LTS to 6.6 LTS, I noticed the ethernet gadget
stopped working on Palm TE.
Commit 8825acd7cc8a ("ARM: omap1: remove dead code") deleted Palm TE from
machine_without_vbus_sense(), although the board is still used. Fix that.
Fixes: 8825acd7cc8a ("ARM: omap1: remove dead code")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/usb/gadget/udc/omap_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c
index 10c5d7f726a1..f90eeecf27de 100644
--- a/drivers/usb/gadget/udc/omap_udc.c
+++ b/drivers/usb/gadget/udc/omap_udc.c
@@ -2036,7 +2036,8 @@ static irqreturn_t omap_udc_iso_irq(int irq, void *_dev)
static inline int machine_without_vbus_sense(void)
{
- return machine_is_omap_osk() || machine_is_sx1();
+ return machine_is_omap_osk() || machine_is_omap_palmte() ||
+ machine_is_sx1();
}
static int omap_udc_start(struct usb_gadget *g,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: omap_udc: fix USB gadget regression on Palm TE
2024-02-17 19:20 [PATCH] usb: gadget: omap_udc: fix USB gadget regression on Palm TE Aaro Koskinen
@ 2024-02-17 20:01 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2024-02-17 20:01 UTC (permalink / raw)
To: Aaro Koskinen, Greg Kroah-Hartman, linux-usb; +Cc: linux-kernel, Linux-OMAP
On Sat, Feb 17, 2024, at 20:20, Aaro Koskinen wrote:
> When upgrading from 6.1 LTS to 6.6 LTS, I noticed the ethernet gadget
> stopped working on Palm TE.
>
> Commit 8825acd7cc8a ("ARM: omap1: remove dead code") deleted Palm TE from
> machine_without_vbus_sense(), although the board is still used. Fix that.
>
> Fixes: 8825acd7cc8a ("ARM: omap1: remove dead code")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Sorry about that, I must have used the wrong regex while
searching for these while removing a lot of the other
palm variants.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-17 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-17 19:20 [PATCH] usb: gadget: omap_udc: fix USB gadget regression on Palm TE Aaro Koskinen
2024-02-17 20:01 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®