From: Gavin Shan <gshan@redhat.com>
To: Liu Shixin <liushixin2@huawei.com>, James Morse <james.morse@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] firmware: arm_sdei: simplify the return expression of sdei_device_freeze()
Date: Wed, 16 Sep 2020 13:40:16 +1000 [thread overview]
Message-ID: <9fdd9c4d-d957-e7d5-818d-cc9247be9dfd@redhat.com> (raw)
In-Reply-To: <20200915032625.1772413-1-liushixin2@huawei.com>
On 9/15/20 1:26 PM, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
Reviewed-by: Gavin Shan <gshan@redhat.com>
> drivers/firmware/arm_sdei.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index b4b9ce97f415..5b4c8c51cb20 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -798,16 +798,10 @@ static int sdei_device_resume(struct device *dev)
> */
> static int sdei_device_freeze(struct device *dev)
> {
> - int err;
> -
> /* unregister private events */
> cpuhp_remove_state(CPUHP_AP_ARM_SDEI_STARTING);
>
> - err = sdei_unregister_shared();
> - if (err)
> - return err;
> -
> - return 0;
> + return sdei_unregister_shared();
> }
>
> static int sdei_device_thaw(struct device *dev)
>
prev parent reply other threads:[~2020-09-16 3:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 3:26 Liu Shixin
2020-09-16 3:40 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdd9c4d-d957-e7d5-818d-cc9247be9dfd@redhat.com \
--to=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome