* [PATCH -next] firmware: arm_sdei: simplify the return expression of sdei_device_freeze()
@ 2020-09-15 3:26 Liu Shixin
2020-09-16 3:40 ` Gavin Shan
0 siblings, 1 reply; 2+ messages in thread
From: Liu Shixin @ 2020-09-15 3:26 UTC (permalink / raw)
To: James Morse; +Cc: linux-arm-kernel, linux-kernel, Liu Shixin
Simplify the return expression.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/firmware/arm_sdei.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index b4b9ce97f415..5b4c8c51cb20 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -798,16 +798,10 @@ static int sdei_device_resume(struct device *dev)
*/
static int sdei_device_freeze(struct device *dev)
{
- int err;
-
/* unregister private events */
cpuhp_remove_state(CPUHP_AP_ARM_SDEI_STARTING);
- err = sdei_unregister_shared();
- if (err)
- return err;
-
- return 0;
+ return sdei_unregister_shared();
}
static int sdei_device_thaw(struct device *dev)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] firmware: arm_sdei: simplify the return expression of sdei_device_freeze()
2020-09-15 3:26 [PATCH -next] firmware: arm_sdei: simplify the return expression of sdei_device_freeze() Liu Shixin
@ 2020-09-16 3:40 ` Gavin Shan
0 siblings, 0 replies; 2+ messages in thread
From: Gavin Shan @ 2020-09-16 3:40 UTC (permalink / raw)
To: Liu Shixin, James Morse; +Cc: linux-kernel, linux-arm-kernel
On 9/15/20 1:26 PM, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
Reviewed-by: Gavin Shan <gshan@redhat.com>
> drivers/firmware/arm_sdei.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index b4b9ce97f415..5b4c8c51cb20 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -798,16 +798,10 @@ static int sdei_device_resume(struct device *dev)
> */
> static int sdei_device_freeze(struct device *dev)
> {
> - int err;
> -
> /* unregister private events */
> cpuhp_remove_state(CPUHP_AP_ARM_SDEI_STARTING);
>
> - err = sdei_unregister_shared();
> - if (err)
> - return err;
> -
> - return 0;
> + return sdei_unregister_shared();
> }
>
> static int sdei_device_thaw(struct device *dev)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-16 3:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 3:26 [PATCH -next] firmware: arm_sdei: simplify the return expression of sdei_device_freeze() Liu Shixin
2020-09-16 3:40 ` Gavin Shan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome