mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
	Sudeep Holla <Sudeep.Holla@arm.com>,
	"linux-pm\@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"lm-sensors\@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	"edubezval\@gmail.com" <edubezval@gmail.com>,
	"linux\@roeck-us.net" <linux@roeck-us.net>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt\@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors
Date: Mon, 14 Sep 2015 15:38:36 +0100	[thread overview]
Message-ID: <9hhk2rtdq1f.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20150914134949.GE7002@leverpostej> (Mark Rutland's message of "Mon, 14 Sep 2015 14:49:49 +0100")

Mark Rutland <mark.rutland@arm.com> writes:

>> >> +Sensor bindings for the sensors based on SCPI Message Protocol
>> >> +--------------------------------------------------------------
>> >> +SCPI provides an API to access the various sensors on the SoC.
>> >> +
>> >> +Required properties:
>> >> +- compatible : should be "arm,scpi-sensors".
>> >> +- #thermal-sensor-cells: should be set to 1. This property follows the
>> >> +			 thermal device tree bindings[2].
>> >
>> > You need to specify what the valid values for this cell are.
>> 
>> The enumeration depends on the number of sensors exported by SCP
>> firmware - which is platform dependent. I could add add something like
>> if you think that is helpful -
>> 
>> "Valid cell value is a number between 0..n-1, where n is the number
>> of sensors exported by SCP firmware."
>
> Can the FW identifer space have holes? Or are they always contiguous?

The way the SCP interface is defined, the sensor identifiers are
contiguous, but not all are temperature sensors.

>
> If this is the same as the raw FW identifer value, specify that.
> Otherwise, you need to specify the mapping.

I'll update the patch to add mappings for Juno r0 (and r1 if I can get
my hands on one).

>
> There needs to be enough information for a dts author to figure out
> which values to place in the DT.

I understand. Except sometimes it is hard to get the firmware to commit to not
modify the ordering - discoverability and all that. :)

>
> Thanks,
> Mark.
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-09-14 14:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 13:00 [PATCH v3 0/5] SCPI Sensor support Punit Agrawal
2015-09-14 13:00 ` [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal
2015-09-14 13:14   ` Mark Rutland
2015-09-14 13:34     ` Punit Agrawal
2015-09-14 13:49       ` Mark Rutland
2015-09-14 14:38         ` Punit Agrawal [this message]
2015-09-14 14:43           ` Mark Rutland
2015-09-14 15:01             ` Punit Agrawal
2015-09-14 15:15               ` Mark Rutland
2015-09-14 16:03                 ` Punit Agrawal
2015-09-14 17:18           ` Jon Medhurst (Tixy)
2015-09-15  9:37             ` Punit Agrawal
2015-09-15 10:46               ` Jon Medhurst (Tixy)
2015-09-15 11:03                 ` Mark Rutland
2015-09-15 11:37                   ` Jon Medhurst (Tixy)
2015-09-15 16:04                 ` Punit Agrawal
2015-09-15 16:31                   ` Jon Medhurst (Tixy)
2015-09-14 13:00 ` [PATCH v3 2/5] firmware: arm_scpi: Extend to support sensors Punit Agrawal
2015-09-14 13:00 ` [PATCH v3 3/5] hwmon: Support sensors exported via ARM SCP interface Punit Agrawal
2015-09-14 13:00 ` [Patch v3 4/5] hwmon: Support registration of thermal zones for SCP temperature sensors Punit Agrawal
2015-09-14 13:19   ` Punit Agrawal
2015-09-14 13:00 ` [PATCH v3 4/5] hwmon: Support thermal zones registration " Punit Agrawal
2015-09-14 13:00 ` [PATCH v3 5/5] arm64: dts: Add sensor node to Juno dt Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9hhk2rtdq1f.fsf@e105922-lin.cambridge.arm.com \
    --to=punit.agrawal@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®