Re: [PATCH] liveupdate: Document that retrieve failure is permanent

[tarunsahu@google.com]

Pratyush Yadav <pratyush@kernel.org> writes:

> On Mon, Jun 08 2026, Tarun Sahu wrote:
>
>> Signed-off-by: Tarun Sahu <tarunsahu@google.com>
>> ---
>>  include/uapi/linux/liveupdate.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h
>> index 30bc66ee9436..a564d2bd05c1 100644
>> --- a/include/uapi/linux/liveupdate.h
>> +++ b/include/uapi/linux/liveupdate.h
>> @@ -168,7 +168,8 @@ struct liveupdate_session_preserve_fd {
>>   * associated with the token and populates the @fd field with a new file
>>   * descriptor referencing the restored resource in the current (new) kernel.
>>   * This operation must be performed *before* signaling completion via
>> - * %LIVEUPDATE_IOCTL_FINISH.
>> + * %LIVEUPDATE_IOCTL_FINISH. Once retrieve call is failed, retrieve status
>> + * is saved. So it is permanent failure and retry is pointless.
>
> Perhaps the wording below is slightly better from a user perspective?
>
>     If a retrieve of a token fails, subsequent attempts to retrieve the
>     token fail with the same error code. Failed retrieves are not
>     retried.

Updated!

>
>>   *
>>   * Return: 0 on success, negative error code on failure (e.g., invalid token).
>>   */
>>
>> base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce
>> prerequisite-patch-id: 30753743cdfab5c3c5355ecde725b6648f1b7a17
>
> -- 
> Regards,
> Pratyush Yadav