mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Linux Bluetooth mailing list  <linux-bluetooth@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Memory (skb) leak in kernel 4.8-rc2
Date: Sat, 20 Aug 2016 08:01:03 +0200	[thread overview]
Message-ID: <A07D8003-F1EB-4408-A3F2-E043DF678296@holtmann.org> (raw)
In-Reply-To: <a62119eb-28d2-7b4d-acbb-6ca8d3a0c91d@lwfinger.net>

Hi Larry,

> I am seeing two skb leaks in the BT sub-system for kernel 4.8-rc2. I only recently re-enabled kmemleak, but I do not think I saw these leaks in 4.7.
> 
> The first leak is at btusb_recv_intr+0x12b/0x170 [btusb]. This address refers to the call to bt_skb_alloc() in routine btusb_recv_intr().

do you have a backtrace for this one? Also which hardware is this?

> The second leak is at hci_event_packet+0xb8/0x30b0 [bluetooth]. The backtrace for this address is
> 
> 0x13d38 is in hci_event_packet (net/bluetooth/hci_event.c:5254).
> 5249             * various handlers may modify the original one through
> 5250             * skb_pull() calls, etc.
> 5251             */
> 5252            if (req_complete_skb || event == HCI_EV_CMD_STATUS ||
> 5253                event == HCI_EV_CMD_COMPLETE)
> 5254                    orig_skb = skb_clone(skb, GFP_KERNEL);
> 5255
> 5256            skb_pull(skb, HCI_EVENT_HDR_SIZE);
> 5257
> 5258            switch (event) {
> 
> I am unable to unload module bluetooth to verify that the second leak is not a false positive; however, the one in btusb is a real memory leak.

I can not see a leak. Maybe Johan has an idea.

Regards

Marcel

  reply	other threads:[~2016-08-20  6:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 21:02 Larry Finger
2016-08-20  6:01 ` Marcel Holtmann [this message]
2016-08-20  7:15   ` Johan Hedberg
2016-08-21 12:09     ` Frederic Dalleau
2016-08-24 20:02       ` Larry Finger
2016-08-25  6:22         ` Frederic Dalleau
2016-08-25 15:27           ` Larry Finger
2016-08-20 16:24   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A07D8003-F1EB-4408-A3F2-E043DF678296@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®