mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Dalleau <frederic.dalleau@collabora.co.uk>
To: Marcel Holtmann <marcel@holtmann.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	"Gustavo F. Padovan" <gustavo@padovan.org>,
	Linux Bluetooth mailing list  <linux-bluetooth@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Memory (skb) leak in kernel 4.8-rc2
Date: Sun, 21 Aug 2016 14:09:58 +0200	[thread overview]
Message-ID: <dd63c403-f35e-2543-e5ba-af40b263ea75@collabora.co.uk> (raw)
In-Reply-To: <20160820071504.GA9663@t440s.P-661HNU-F1>

Hi Marcel, Johan,

>>> I am unable to unload module bluetooth to verify that the second
>>> leak is not a false positive; however, the one in btusb is a real
>>> memory leak.

There was a bugzilla last week with that backtrace: 
https://bugzilla.kernel.org/show_bug.cgi?id=120691

At the time, I was thinking that the leak could originate from one of 
the req_complete_skb callback, but which one?

And today that the issue has popped again, I found that 
hci_req_sync_complete references the skb in hdev->req_skb. It is called 
(via hci_req_run_skb) from either __hci_cmd_sync_ev which will pass the 
skb to the caller, or __hci_req_sync which leaks.

I have a patch on the grill.

Best Regards,
Frédéric

  reply	other threads:[~2016-08-21 12:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 21:02 Larry Finger
2016-08-20  6:01 ` Marcel Holtmann
2016-08-20  7:15   ` Johan Hedberg
2016-08-21 12:09     ` Frederic Dalleau [this message]
2016-08-24 20:02       ` Larry Finger
2016-08-25  6:22         ` Frederic Dalleau
2016-08-25 15:27           ` Larry Finger
2016-08-20 16:24   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd63c403-f35e-2543-e5ba-af40b263ea75@collabora.co.uk \
    --to=frederic.dalleau@collabora.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®