mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bradley Morgan <brads@mainlining.org>
To: "Steven Rostedt" <rostedt@goodmis.org>,
	"Jérémy Jean" <Jeremy.Jean@oss.cyber.gouv.fr>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] tracing/user_events: Clear copied tracing state before fork duplication
Date: Thu, 27 Aug 2026 13:09:44 +0100	[thread overview]
Message-ID: <A4F580CE-2211-4D05-9D3D-15AB427C74A4@mainlining.org> (raw)
In-Reply-To: <20260827080839.35e44d04@gandalf.local.home>

On 27 August 2026 13:08:39 BST, Steven Rostedt <rostedt@goodmis.org> wrote:
>On Wed, 26 Aug 2026 21:44:15 +0000
>Jérémy Jean <Jeremy.Jean@oss.cyber.gouv.fr> wrote:
>> diff --git a/kernel/trace/trace_events_user.c
>b/kernel/trace/trace_events_user.c
>> index 2bbc89d4a266..339e18085af3 100644
>> --- a/kernel/trace/trace_events_user.c
>> +++ b/kernel/trace/trace_events_user.c
>> @@ -865,9 +865,12 @@ void user_event_mm_remove(struct task_struct *t)
>>  
>>  void user_event_mm_dup(struct task_struct *t, struct user_event_mm
>*old_mm)
>>  {
>> -	struct user_event_mm *mm = user_event_mm_alloc(t);
>> +	struct user_event_mm *mm;
>
>Why this change?
>
>>  	struct user_event_enabler *enabler;
>>  
>> +	t->user_event_mm = NULL;
>> +	mm = user_event_mm_alloc(t);
>
>I don't see why you moved the mm assignment down here. The
>t->user_event_mm
>is not used in user_event_mm_alloc().

Uff, not wrong, I must be dummy dumb dumb, well, I base my reviews off 

Does this fix the bug? And is this a small fix?


>
>-- Steve
>
>> +
>>  	if (!mm)
>>  		return;
>>  
>

--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/

  reply	other threads:[~2026-08-27 12:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 21:44 Jérémy Jean
2026-08-26 22:37 ` Bradley Morgan
2026-08-27  7:15   ` Jérémy Jean
2026-08-27  9:45     ` Bradley Morgan
2026-08-27 12:15       ` Steven Rostedt
2026-08-27 12:17         ` Bradley Morgan
2026-08-27 12:08 ` Steven Rostedt
2026-08-27 12:09   ` Bradley Morgan [this message]
2026-08-27 12:19     ` Steven Rostedt
2026-08-27 12:24       ` Bradley Morgan
2026-08-27 12:27       ` Jérémy Jean
2026-08-27 12:29         ` Bradley Morgan
2026-08-27 12:43           ` Steven Rostedt
2026-08-27 12:44             ` Bradley Morgan
2026-08-27 12:42         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A4F580CE-2211-4D05-9D3D-15AB427C74A4@mainlining.org \
    --to=brads@mainlining.org \
    --cc=Jeremy.Jean@oss.cyber.gouv.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®