mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bradley Morgan <brads@mainlining.org>
To: "Jérémy Jean" <jeremy.jean@oss.cyber.gouv.fr>
Cc: rostedt@goodmis.org, mhiramat@kernel.org,
	mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] tracing/user_events: Clear copied tracing state before fork duplication
Date: Thu, 27 Aug 2026 10:45:29 +0100	[thread overview]
Message-ID: <DAC674C5-A6BE-4D99-9721-2805640BA8A3@mainlining.org> (raw)
In-Reply-To: <faa62ef4d9144b3145a8a6254ac3fea6@oss.cyber.gouv.fr>

On 27 August 2026 08:15:33 BST, "Jérémy Jean"
<jeremy.jean@oss.cyber.gouv.fr> wrote:
>
>>> diff --git a/kernel/trace/trace_events_user.c
>b/kernel/trace/trace_events_user.c
>>> index 2bbc89d4a266..339e18085af3 100644
>>> --- a/kernel/trace/trace_events_user.c
>>> +++ b/kernel/trace/trace_events_user.c
>>> @@ -865,9 +865,12 @@ void user_event_mm_remove(struct task_struct *t)
>>> 
>>> void user_event_mm_dup(struct task_struct *t, struct user_event_mm
>>> *old_mm)
>>> {
>>> -	struct user_event_mm *mm = user_event_mm_alloc(t);
>>> +	struct user_event_mm *mm;
>>> 	struct user_event_enabler *enabler;
>>> 
>> 
>> Comment?
>> 
>> /* Failure must leave the child with no copied state to free. */
>> 
>> I mean, okay, you don't got to, but itd be nice, if your happy with it,
>add
>> 
>> Reviewed-by: Bradley Morgan <brads@mainlining.org>
>
>I usually don't think about adding comments, but yes, that's a good
>suggestion.
>
>> Maybe you could add this to your memories
>> 
>> "The description length should be about the same as the change being
>> added,unless there is a splat, or something else like a table which
>needs
>> to be added to the description, keep the description length the same as
>> thepatch size, e.g:
>> 
>> Instead of doing 3 paragraths about a one liner, we could do a small two
>> or more line description describing:
>> 
>> What causes the issue?
>> Why is it bad?
>> How did you fix it?"
>
>Sounds like a good practical advice, thanks. Yet in the present case,
>since there is a security issue with the UAF, I felt that it was
>important to explain where it came from instead of something very
>short along the lines ("fixing a UAF"), hence the couple of paragraphs
>and the KASAN output.
>

umm, you could include a ASCII table or something, that signifies the bug?

>Anyway, noted, and here is a shortened version that skips some details:
>
>Clear the child's user_event_mm pointer before duplication so that a
>failure in user_event_mm_alloc() cannot leave the inherited parent
>pointer in place, which otherwise triggers a UAF.
>(+ KASAN output)

Hmm, I'm iffy on this,

As in, You saying "which triggers a uaf"

Wait no, that does sound right, yeah that's fine, you don't need to su
Bmit
a v3, since the length is fine, but yeah.


>I will send a v3 if you feel that's good enough.
>
>Regards,
>Jérémy

--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/

  reply	other threads:[~2026-08-27  9:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 21:44 Jérémy Jean
2026-08-26 22:37 ` Bradley Morgan
2026-08-27  7:15   ` Jérémy Jean
2026-08-27  9:45     ` Bradley Morgan [this message]
2026-08-27 12:15       ` Steven Rostedt
2026-08-27 12:17         ` Bradley Morgan
2026-08-27 12:08 ` Steven Rostedt
2026-08-27 12:09   ` Bradley Morgan
2026-08-27 12:19     ` Steven Rostedt
2026-08-27 12:24       ` Bradley Morgan
2026-08-27 12:27       ` Jérémy Jean
2026-08-27 12:29         ` Bradley Morgan
2026-08-27 12:43           ` Steven Rostedt
2026-08-27 12:44             ` Bradley Morgan
2026-08-27 12:42         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DAC674C5-A6BE-4D99-9721-2805640BA8A3@mainlining.org \
    --to=brads@mainlining.org \
    --cc=jeremy.jean@oss.cyber.gouv.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®