From: "Zhang, Yang Z" <yang.z.zhang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Subject: RE: [PATCH] KVM: x86: always set accessed bit in shadow PTEs
Date: Tue, 17 Nov 2015 00:59:30 +0000 [thread overview]
Message-ID: <A9667DDFB95DB7438FA9D7D576C3D87E0AE12CC2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1447412302-3504-1-git-send-email-pbonzini@redhat.com>
Paolo Bonzini wrote on 2015-11-13:
> Commit 7a1638ce4220 ("nEPT: Redefine EPT-specific link_shadow_page()",
> 2013-08-05) says:
>
> Since nEPT doesn't support A/D bit, we should not set those bit
> when building the shadow page table.
> but this is not necessary. Even though nEPT doesn't support A/D
> bits, and hence the vmcs12 EPT pointer will never enable them,
> we always use them for shadow page tables if available (see
> construct_eptp in vmx.c). So we can set the A/D bits freely
> in the shadow page table.
>
> This patch hence basically reverts commit 7a1638ce4220.
>
> Cc: Yang Zhang <yang.z.zhang@Intel.com>
> Cc: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Looks good to me.
Best regards,
Yang
prev parent reply other threads:[~2015-11-17 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 10:58 Paolo Bonzini
2015-11-17 0:59 ` Zhang, Yang Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A9667DDFB95DB7438FA9D7D576C3D87E0AE12CC2@SHSMSX104.ccr.corp.intel.com \
--to=yang.z.zhang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®