mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kmemleak: build kmemleak-test.c as a module-only
@ 2011-03-16 18:16 Daniel Baluta
  2011-03-23 11:18 ` Daniel Baluta
  2011-03-23 11:24 ` Catalin Marinas
  0 siblings, 2 replies; 8+ messages in thread
From: Daniel Baluta @ 2011-03-16 18:16 UTC (permalink / raw)
  To: paulmck
  Cc: akpm, mingo, fweisbec, rdunlap, linux-kernel, catalin.marinas,
	Daniel Baluta

mm/kmemleak-test.c is used to provide an example of how kmemleak
tool works.

Memory is leaked at module unload-time, so building the test
in kernel (Y) makes the leaks impossible and the test useless.

Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
to restrict module-only building.

Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
---
 lib/Kconfig.debug |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 689f311..6e9cacc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -407,11 +407,9 @@ config DEBUG_KMEMLEAK_EARLY_LOG_SIZE
 
 config DEBUG_KMEMLEAK_TEST
 	tristate "Simple test for the kernel memory leak detector"
-	depends on DEBUG_KMEMLEAK
+	depends on DEBUG_KMEMLEAK && m
 	help
-	  Say Y or M here to build a test for the kernel memory leak
-	  detector. This option enables a module that explicitly leaks
-	  memory.
+	  This option enables a module that explicitly leaks memory.
 
 	  If unsure, say N.
 
-- 
1.7.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-16 18:16 [PATCH] kmemleak: build kmemleak-test.c as a module-only Daniel Baluta
@ 2011-03-23 11:18 ` Daniel Baluta
  2011-03-23 11:23   ` Pekka Enberg
  2011-03-23 11:24 ` Catalin Marinas
  1 sibling, 1 reply; 8+ messages in thread
From: Daniel Baluta @ 2011-03-23 11:18 UTC (permalink / raw)
  To: paulmck, Catalin Marinas; +Cc: akpm, mingo, fweisbec, rdunlap, linux-kernel

On Wed, Mar 16, 2011 at 8:16 PM, Daniel Baluta <dbaluta@ixiacom.com> wrote:
> mm/kmemleak-test.c is used to provide an example of how kmemleak
> tool works.
>
> Memory is leaked at module unload-time, so building the test
> in kernel (Y) makes the leaks impossible and the test useless.

Any comments on this?

thanks,
Daniel.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-23 11:18 ` Daniel Baluta
@ 2011-03-23 11:23   ` Pekka Enberg
  0 siblings, 0 replies; 8+ messages in thread
From: Pekka Enberg @ 2011-03-23 11:23 UTC (permalink / raw)
  To: Daniel Baluta
  Cc: paulmck, Catalin Marinas, akpm, mingo, fweisbec, rdunlap, linux-kernel

On Wed, Mar 23, 2011 at 1:18 PM, Daniel Baluta <daniel.baluta@gmail.com> wrote:
> On Wed, Mar 16, 2011 at 8:16 PM, Daniel Baluta <dbaluta@ixiacom.com> wrote:
>> mm/kmemleak-test.c is used to provide an example of how kmemleak
>> tool works.
>>
>> Memory is leaked at module unload-time, so building the test
>> in kernel (Y) makes the leaks impossible and the test useless.
>
> Any comments on this?

Looks good to me.

Acked-by: Pekka Enberg <penberg@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-16 18:16 [PATCH] kmemleak: build kmemleak-test.c as a module-only Daniel Baluta
  2011-03-23 11:18 ` Daniel Baluta
@ 2011-03-23 11:24 ` Catalin Marinas
  2011-03-25 14:05   ` Daniel Baluta
  1 sibling, 1 reply; 8+ messages in thread
From: Catalin Marinas @ 2011-03-23 11:24 UTC (permalink / raw)
  To: Daniel Baluta; +Cc: paulmck, akpm, mingo, fweisbec, rdunlap, linux-kernel

On Wed, 2011-03-16 at 18:16 +0000, Daniel Baluta wrote:
> mm/kmemleak-test.c is used to provide an example of how kmemleak
> tool works.
> 
> Memory is leaked at module unload-time, so building the test
> in kernel (Y) makes the leaks impossible and the test useless.
> 
> Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
> to restrict module-only building.
> 
> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>

Sorry for the delay.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-23 11:24 ` Catalin Marinas
@ 2011-03-25 14:05   ` Daniel Baluta
  2011-03-30 15:02     ` Daniel Baluta
  0 siblings, 1 reply; 8+ messages in thread
From: Daniel Baluta @ 2011-03-25 14:05 UTC (permalink / raw)
  To: Catalin Marinas, paulmck, akpm, mingo, fweisbec, rdunlap; +Cc: linux-kernel

On Wed, Mar 23, 2011 at 1:24 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> On Wed, 2011-03-16 at 18:16 +0000, Daniel Baluta wrote:
>> mm/kmemleak-test.c is used to provide an example of how kmemleak
>> tool works.
>>
>> Memory is leaked at module unload-time, so building the test
>> in kernel (Y) makes the leaks impossible and the test useless.
>>
>> Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
>> to restrict module-only building.
>>
>> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
>
> Sorry for the delay.
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Who should pick this up?

$ scripts/get_maintainer.pl lib/this.patch says:
Andrew Morton <akpm@linux-foundation.org> (commit_signer:8/56=14%)
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> (commit_signer:7/56=12%)
Ingo Molnar <mingo@elte.hu> (commit_signer:5/56=9%)
Frederic Weisbecker <fweisbec@gmail.com> (commit_signer:5/56=9%)
Randy Dunlap <rdunlap@xenotime.net> (commit_signer:3/56=5%)

Am I missing something?

thanks,
Daniel.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-25 14:05   ` Daniel Baluta
@ 2011-03-30 15:02     ` Daniel Baluta
  2011-03-30 15:24       ` Randy Dunlap
  0 siblings, 1 reply; 8+ messages in thread
From: Daniel Baluta @ 2011-03-30 15:02 UTC (permalink / raw)
  To: Catalin Marinas, rdunlap
  Cc: paulmck, akpm, mingo, fweisbec, Linux Kernel Mailing List, penberg

On Fri, Mar 25, 2011 at 4:05 PM, Daniel Baluta <dbaluta@ixiacom.com> wrote:
> On Wed, Mar 23, 2011 at 1:24 PM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
>> On Wed, 2011-03-16 at 18:16 +0000, Daniel Baluta wrote:
>>> mm/kmemleak-test.c is used to provide an example of how kmemleak
>>> tool works.
>>>
>>> Memory is leaked at module unload-time, so building the test
>>> in kernel (Y) makes the leaks impossible and the test useless.
>>>
>>> Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
>>> to restrict module-only building.
>>>
>>> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
>>
>> Sorry for the delay.
>>
>> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
> Who should pick this up?
>
> $ scripts/get_maintainer.pl lib/this.patch says:
> Andrew Morton <akpm@linux-foundation.org> (commit_signer:8/56=14%)
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> (commit_signer:7/56=12%)
> Ingo Molnar <mingo@elte.hu> (commit_signer:5/56=9%)
> Frederic Weisbecker <fweisbec@gmail.com> (commit_signer:5/56=9%)
> Randy Dunlap <rdunlap@xenotime.net> (commit_signer:3/56=5%)

Catalin, Randy since lib/Kconfig.debug has no official maintainer
I think this should go up through your trees.

thanks,
Daniel.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-30 15:02     ` Daniel Baluta
@ 2011-03-30 15:24       ` Randy Dunlap
  2011-03-31  7:44         ` Daniel Baluta
  0 siblings, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2011-03-30 15:24 UTC (permalink / raw)
  To: Daniel Baluta
  Cc: Catalin Marinas, paulmck, akpm, mingo, fweisbec,
	Linux Kernel Mailing List, penberg

On Wed, 30 Mar 2011 18:02:02 +0300 Daniel Baluta wrote:

> On Fri, Mar 25, 2011 at 4:05 PM, Daniel Baluta <dbaluta@ixiacom.com> wrote:
> > On Wed, Mar 23, 2011 at 1:24 PM, Catalin Marinas
> > <catalin.marinas@arm.com> wrote:
> >> On Wed, 2011-03-16 at 18:16 +0000, Daniel Baluta wrote:
> >>> mm/kmemleak-test.c is used to provide an example of how kmemleak
> >>> tool works.
> >>>
> >>> Memory is leaked at module unload-time, so building the test
> >>> in kernel (Y) makes the leaks impossible and the test useless.
> >>>
> >>> Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
> >>> to restrict module-only building.
> >>>
> >>> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
> >>
> >> Sorry for the delay.
> >>
> >> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> >
> > Who should pick this up?
> >
> > $ scripts/get_maintainer.pl lib/this.patch says:
> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:8/56=14%)
> > "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> (commit_signer:7/56=12%)
> > Ingo Molnar <mingo@elte.hu> (commit_signer:5/56=9%)
> > Frederic Weisbecker <fweisbec@gmail.com> (commit_signer:5/56=9%)
> > Randy Dunlap <rdunlap@xenotime.net> (commit_signer:3/56=5%)
> 
> Catalin, Randy since lib/Kconfig.debug has no official maintainer
> I think this should go up through your trees.

I hadn't seen it until now, but I can merge it.

thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] kmemleak: build kmemleak-test.c as a module-only
  2011-03-30 15:24       ` Randy Dunlap
@ 2011-03-31  7:44         ` Daniel Baluta
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Baluta @ 2011-03-31  7:44 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Catalin Marinas, paulmck, akpm, mingo, fweisbec,
	Linux Kernel Mailing List, penberg

On Wed, Mar 30, 2011 at 6:24 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Wed, 30 Mar 2011 18:02:02 +0300 Daniel Baluta wrote:
>
>> On Fri, Mar 25, 2011 at 4:05 PM, Daniel Baluta <dbaluta@ixiacom.com> wrote:
>> > On Wed, Mar 23, 2011 at 1:24 PM, Catalin Marinas
>> > <catalin.marinas@arm.com> wrote:
>> >> On Wed, 2011-03-16 at 18:16 +0000, Daniel Baluta wrote:
>> >>> mm/kmemleak-test.c is used to provide an example of how kmemleak
>> >>> tool works.
>> >>>
>> >>> Memory is leaked at module unload-time, so building the test
>> >>> in kernel (Y) makes the leaks impossible and the test useless.
>> >>>
>> >>> Qualify DEBUG_KMEMLEAK_TEST config symbol with "depends on m",
>> >>> to restrict module-only building.
>> >>>
>> >>> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
>> >>
>> >> Sorry for the delay.
>> >>
>> >> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>> >
>> > Who should pick this up?
>> >
>> > $ scripts/get_maintainer.pl lib/this.patch says:
>> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:8/56=14%)
>> > "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> (commit_signer:7/56=12%)
>> > Ingo Molnar <mingo@elte.hu> (commit_signer:5/56=9%)
>> > Frederic Weisbecker <fweisbec@gmail.com> (commit_signer:5/56=9%)
>> > Randy Dunlap <rdunlap@xenotime.net> (commit_signer:3/56=5%)
>>
>> Catalin, Randy since lib/Kconfig.debug has no official maintainer
>> I think this should go up through your trees.
>
> I hadn't seen it until now, but I can merge it.

OK. thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-03-31  7:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-16 18:16 [PATCH] kmemleak: build kmemleak-test.c as a module-only Daniel Baluta
2011-03-23 11:18 ` Daniel Baluta
2011-03-23 11:23   ` Pekka Enberg
2011-03-23 11:24 ` Catalin Marinas
2011-03-25 14:05   ` Daniel Baluta
2011-03-30 15:02     ` Daniel Baluta
2011-03-30 15:24       ` Randy Dunlap
2011-03-31  7:44         ` Daniel Baluta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®