From: saeed bishara <saeed.bishara@gmail.com>
To: Robin Becker <replabrobin@gmail.com>
Cc: kernel@wantstofly.org, nico@fluxnic.net, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, replabrobin <robin@reportlab.com>
Subject: Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and add support for second LED This is a patch to the sheevaplug-setup.c file that fixes the color name of the existing health LED. That LED gpio 49 is green when off and blue when on. The pat
Date: Wed, 9 Mar 2011 16:16:41 +0200 [thread overview]
Message-ID: <AANLkTinydE-N2eVgq5aF4m31Asd8sWO2sNgO5tjcGDU6@mail.gmail.com> (raw)
On Wed, Mar 9, 2011 at 3:27 PM, Robin Becker <replabrobin@gmail.com> wrote:
> From: replabrobin <robin@reportlab.com>
please use short subject for this commit, and move the description
into the commit description section
aslo, I would split this to two patches, one fixes the LED color name,
the second for adding the new LED.
> static unsigned int sheevaplug_mpp_config[] __initdata = {
> MPP29_GPIO, /* USB Power Enable */
> - MPP49_GPIO, /* LED */
> + MPP46_GPIO, /* RED LED */
> + MPP49_GPIO, /* BLUE LED */
> 0
> };
>
> static unsigned int sheeva_esata_mpp_config[] __initdata = {
> MPP29_GPIO, /* USB Power Enable */
> MPP44_GPIO, /* SD Write Protect */
> + MPP46_GPIO, /* RED LED */
> MPP47_GPIO, /* SD Card Detect */
> MPP49_GPIO, /* LED Green */
please fix the comment as well
reply other threads:[~2011-03-09 14:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinydE-N2eVgq5aF4m31Asd8sWO2sNgO5tjcGDU6@mail.gmail.com \
--to=saeed.bishara@gmail.com \
--cc=kernel@wantstofly.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=replabrobin@gmail.com \
--cc=robin@reportlab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®