mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and add support for second LED This is a patch to the sheevaplug-setup.c file that fixes the color name of the existing health LED. That LED gpio 49 is green when off and blue when on. The pat
@ 2011-03-09 14:16 saeed bishara
  0 siblings, 0 replies; only message in thread
From: saeed bishara @ 2011-03-09 14:16 UTC (permalink / raw)
  To: Robin Becker
  Cc: kernel, nico, linux, linux-arm-kernel, linux-kernel, replabrobin

On Wed, Mar 9, 2011 at 3:27 PM, Robin Becker <replabrobin@gmail.com> wrote:
> From: replabrobin <robin@reportlab.com>
please use short subject for this commit, and move the description
into the commit description section
aslo, I would split this to two patches, one fixes the LED color name,
the second for adding the new LED.

>  static unsigned int sheevaplug_mpp_config[] __initdata = {
>        MPP29_GPIO,     /* USB Power Enable */
> -       MPP49_GPIO,     /* LED */
> +       MPP46_GPIO,     /* RED LED */
> +       MPP49_GPIO,     /* BLUE LED */
>        0
>  };
>
>  static unsigned int sheeva_esata_mpp_config[] __initdata = {
>        MPP29_GPIO,     /* USB Power Enable */
>        MPP44_GPIO,     /* SD Write Protect */
> +       MPP46_GPIO,     /* RED LED */
>        MPP47_GPIO,     /* SD Card Detect */
>        MPP49_GPIO,     /* LED Green */
please fix the comment as well

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-03-09 14:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-09 14:16 [PATCH] stable: sheevaplug-setup.c fix LED color name and add support for second LED This is a patch to the sheevaplug-setup.c file that fixes the color name of the existing health LED. That LED gpio 49 is green when off and blue when on. The pat saeed bishara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®