From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
To: John Garry <john.garry@huawei.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linuxarm@huawei.com, zhangfei.gao@linaro.org,
xuwei5@hisilicon.com, john.garry2@mail.dcu.ie,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1_hw()
Date: Thu, 7 Jan 2016 22:51:10 -0600 [thread overview]
Message-ID: <AC4CAD57-D230-4F26-9DCB-2F1FCECBCC4E@linux.vnet.ibm.com> (raw)
In-Reply-To: <1450697709-120516-4-git-send-email-john.garry@huawei.com>
> On Dec 21, 2015, at 5:35 AM, John Garry <john.garry@huawei.com> wrote:
>
> By reading in itct.qw0 into a 32b variable the top
> 32 bits were being lost.
> In practice this was OK as they were zeroes.
>
> Fixes: 27a3f229 ("hisi_sas: Add cq interrupt")
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> index 38ff575..057fdeb 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> @@ -539,7 +539,8 @@ static void free_device_v1_hw(struct hisi_hba *hisi_hba,
> {
> u64 dev_id = sas_dev->device_id;
> struct hisi_sas_itct *itct = &hisi_hba->itct[dev_id];
> - u32 qw0, reg_val = hisi_sas_read32(hisi_hba, CFG_AGING_TIME);
> + u64 qw0;
This should probably be a __le64, but not a big deal.
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
next prev parent reply other threads:[~2016-01-08 4:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 11:35 [PATCH 0/3] hisi_sas v1 hw itct fixes John Garry
2015-12-21 11:35 ` [PATCH 1/3] hisi_sas: fix v1 itct masks John Garry
2016-01-08 4:31 ` Seymour, Shane M
2016-01-08 4:37 ` Matthew R. Ochs
2015-12-21 11:35 ` [PATCH 2/3] hisi_sas: fix typo in setup_itct_v1_hw() John Garry
2016-01-08 4:30 ` Seymour, Shane M
2016-01-08 4:40 ` Matthew R. Ochs
2015-12-21 11:35 ` [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1_hw() John Garry
2016-01-08 4:29 ` Seymour, Shane M
2016-01-08 4:51 ` Matthew R. Ochs [this message]
2016-01-08 17:13 ` [PATCH 0/3] hisi_sas v1 hw itct fixes Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC4CAD57-D230-4F26-9DCB-2F1FCECBCC4E@linux.vnet.ibm.com \
--to=mrochs@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®