From: "James Harper" <JamesH@bendigoit.com.au>
To: <linux-kernel@vger.kernel.org>
Cc: <chessman@tux.org>
Subject: [PATCH] 2.4.26 fix PROMISC/bridging in TLAN driver
Date: Mon, 5 Jul 2004 12:25:27 +1000 [thread overview]
Message-ID: <AEC6C66638C05B468B556EA548C1A77D2500D2@trantor> (raw)
This has been a problem for me for ages. When using bridging, the driver
is switched into promiscuous mode before the link init is complete. The
init complete routine then resets the promisc bit on the card so the
kernel still thinks the card is in promiscuous mode but the card isn't.
doh.
I think this bug only shows up in bridging when the bridge is started at
boot time (or something else that sets promisc at the same time the card
was started). If promisc is enabled later it works.
Here's a trivial (and hopefully correct) patch that works for me. It
just calls the promisc/multicast setup routine after init.
James
--- linux/drivers/net/tlan.c 2004-07-05 12:10:31.000000000 +1000
+++ linux-2.4.26-xen0/drivers/net/tlan.c 2004-07-05
11:43:48.000000000 +1000
@@ -2378,6 +2378,7 @@
TLan_SetTimer( dev, (10*HZ), TLAN_TIMER_FINISH_RESET );
return;
}
+ TLan_SetMulticastList(dev);
} /* TLan_FinishReset */
reply other threads:[~2004-07-05 2:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AEC6C66638C05B468B556EA548C1A77D2500D2@trantor \
--to=jamesh@bendigoit.com.au \
--cc=chessman@tux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®