* [PATCH] 2.4.26 fix PROMISC/bridging in TLAN driver
@ 2004-07-05 2:25 James Harper
0 siblings, 0 replies; only message in thread
From: James Harper @ 2004-07-05 2:25 UTC (permalink / raw)
To: linux-kernel; +Cc: chessman
This has been a problem for me for ages. When using bridging, the driver
is switched into promiscuous mode before the link init is complete. The
init complete routine then resets the promisc bit on the card so the
kernel still thinks the card is in promiscuous mode but the card isn't.
doh.
I think this bug only shows up in bridging when the bridge is started at
boot time (or something else that sets promisc at the same time the card
was started). If promisc is enabled later it works.
Here's a trivial (and hopefully correct) patch that works for me. It
just calls the promisc/multicast setup routine after init.
James
--- linux/drivers/net/tlan.c 2004-07-05 12:10:31.000000000 +1000
+++ linux-2.4.26-xen0/drivers/net/tlan.c 2004-07-05
11:43:48.000000000 +1000
@@ -2378,6 +2378,7 @@
TLan_SetTimer( dev, (10*HZ), TLAN_TIMER_FINISH_RESET );
return;
}
+ TLan_SetMulticastList(dev);
} /* TLan_FinishReset */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-07-05 2:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-05 2:25 [PATCH] 2.4.26 fix PROMISC/bridging in TLAN driver James Harper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®