From: "James Harper" <james.harper@bendigoit.com.au>
To: <linux-kernel@vger.kernel.org>
Subject: flawed assumption in via-rhine (or bug in skb_pad)?
Date: Wed, 22 Feb 2006 15:24:12 +1100 [thread overview]
Message-ID: <AEC6C66638C05B468B556EA548C1A77DAF098F@trantor> (raw)
Should the 'len' field of an skb be updated by a call to skb_pad? I'm
guessing not...
The via-rhine drive does a skb_padto (which in turn calls skb_pad) to
ensure that the skb contains enough bits to satisfy the ethernet minimum
packet size, but then it goes and uses skb->len everywhere else, which
seems like it is assuming that skb->len is incrememted...
The documentation in via-rhine (which I can only assume is correct)
specifically states that the hardware does not do padding, so the driver
would have to explicitly bump the length.
Whatever the cause, I'm getting runt frames and I don't like it :)
Thanks
James
reply other threads:[~2006-02-22 4:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AEC6C66638C05B468B556EA548C1A77DAF098F@trantor \
--to=james.harper@bendigoit.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®