* flawed assumption in via-rhine (or bug in skb_pad)?
@ 2006-02-22 4:24 James Harper
0 siblings, 0 replies; only message in thread
From: James Harper @ 2006-02-22 4:24 UTC (permalink / raw)
To: linux-kernel
Should the 'len' field of an skb be updated by a call to skb_pad? I'm
guessing not...
The via-rhine drive does a skb_padto (which in turn calls skb_pad) to
ensure that the skb contains enough bits to satisfy the ethernet minimum
packet size, but then it goes and uses skb->len everywhere else, which
seems like it is assuming that skb->len is incrememted...
The documentation in via-rhine (which I can only assume is correct)
specifically states that the hardware does not do padding, so the driver
would have to explicitly bump the length.
Whatever the cause, I'm getting runt frames and I don't like it :)
Thanks
James
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-22 4:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-22 4:24 flawed assumption in via-rhine (or bug in skb_pad)? James Harper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®