mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Fang <wei.fang@nxp.com>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: dl-S32 <S32@nxp.com>, Vladimir Oltean <vladimir.oltean@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v1 2/5] net: enetc: Enable probing of version 4.4 devices
Date: Tue, 13 Oct 2026 02:23:03 +0000	[thread overview]
Message-ID: <AS4PR04MB93383ECAB9896DD89629CB8D889E2@AS4PR04MB9338.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <GV2PR04MB11740B17401171A7F3876B6E0969F2@GV2PR04MB11740.eurprd04.prod.outlook.com>


NXP Confidential
> From: Wei Fang <wei.fang@nxp.com>
> Sent: Saturday, October 10, 2026 5:02 AM [...]
> > Subject: RE: [PATCH net-next v1 2/5] net: enetc: Enable probing of
> > version 4.4 devices
> >
> > > The ENETC v4.4 devices are present on S32N79 SoCs and feature only
> > > Pseudo-MAC ENETC ports, whose PFs expose both the 0xe101 and 0xe110
> >
> > I think the device ID of the ENETC PF with the pseudo MAC should be 0xe110.
> > The device ID 0xe101 should be only used for the standalone ENETCs
> > (without pseudo MAC). Is this a hardware issue? If so, a workaround is
> > to set these PF's device ID to 0xe110 in IERB module. Then the device
> > ID 0xe110 will be present in the PCIe ECAM space.
> >
>
> Ok, will consider going forward with 0xe110 exclusively, in v2.
> Thanks.

As Alex explained in the internal mail thread, the device ID is not related
to pseudo MAC vs physic MAC. The device ID 0xe110 is used for switch
management port, and the device ID 0xe101 is used for non-management
port. So the current patch is fine, the only thing that needs improvement is
to include this in the commit message to avoid causing the same confusion
for others as I have.


  reply	other threads:[~2026-10-13  2:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1791548316.git.claudiu.manoil@nxp.com>
2026-10-09 12:40 ` [PATCH net-next v1 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a DT overlay Claudiu Manoil
2026-10-10  2:26   ` Frank Li
2026-10-12  7:37     ` Claudiu Manoil
2026-10-09 12:40 ` [PATCH net-next v1 2/5] net: enetc: Enable probing of version 4.4 devices Claudiu Manoil
2026-10-10  2:01   ` Wei Fang
2026-10-12  7:45     ` Claudiu Manoil
2026-10-13  2:23       ` Wei Fang [this message]
2026-10-09 12:40 ` [PATCH net-next v1 3/5] arm64: dts: s32n79: add NETC IEP18 ECAM node for ENETC PPM ports Claudiu Manoil
2026-10-09 12:40 ` [PATCH net-next v1 4/5] arm64: dts: s32n79-rdb: enable NETC IEP18 Claudiu Manoil
2026-10-09 12:40 ` [PATCH net-next v1 5/5] PCI: Create OF node for NXP ENETC pseudo-MAC functions Claudiu Manoil
2026-10-09 15:29   ` Bjorn Helgaas
2026-10-10 13:13 [PATCH net-next v1 2/5] net: enetc: Enable probing of version 4.4 devices netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR04MB93383ECAB9896DD89629CB8D889E2@AS4PR04MB9338.eurprd04.prod.outlook.com \
    --to=wei.fang@nxp.com \
    --cc=S32@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®