mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: "Frank Li (OSS)" <frank.li@oss.nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	dl-S32 <S32@nxp.com>, Vladimir Oltean <vladimir.oltean@nxp.com>,
	Wei Fang <wei.fang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH net-next v1 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a DT overlay
Date: Mon, 12 Oct 2026 07:37:30 +0000	[thread overview]
Message-ID: <GV2PR04MB117404685DA7A4291E5D41AF2969F2@GV2PR04MB11740.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <asmiQded6KfagAcZ@SMW015318>

> From: Frank Li (OSS) <frank.li@oss.nxp.com>
> Sent: Saturday, October 10, 2026 5:26 AM
[...]
> Subject: Re: [PATCH net-next v1 1/5] net: enetc: Add pseudo-MAC support for
> ENETCv4 Ports via a DT overlay
> 
> On Fri, Oct 09, 2026 at 03:40:30PM +0300, Claudiu Manoil wrote:
> >
[...]
> >  .../freescale/enetc/enetc4_pseudo_mac.dtso    | 32 ++++++
> 
> Not sure why need dt overlay here, there are already dymatic update dts by
> of_changeset_* API, like of_changeset_create_node().
> 

Ok, of_changeset_create_node() looks better to me too. Probably I missed this
option because only one driver to date uses this function and I was focused on
the lan966x approach.

The of_changeset_create_node() approach would also address the limitation
regarding the advertised/supported speed displayed by phylink (I was aware of)
that also Sashiko found as medium severity issue. Likely this approach will
address the other Med severity issues found on this patch too.

Thanks.

  reply	other threads:[~2026-10-12  7:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1791548316.git.claudiu.manoil@nxp.com>
2026-10-09 12:40 ` Claudiu Manoil
2026-10-10  2:26   ` Frank Li
2026-10-12  7:37     ` Claudiu Manoil [this message]
2026-10-09 12:40 ` [PATCH net-next v1 2/5] net: enetc: Enable probing of version 4.4 devices Claudiu Manoil
2026-10-10  2:01   ` Wei Fang
2026-10-12  7:45     ` Claudiu Manoil
2026-10-13  2:23       ` Wei Fang
2026-10-09 12:40 ` [PATCH net-next v1 3/5] arm64: dts: s32n79: add NETC IEP18 ECAM node for ENETC PPM ports Claudiu Manoil
2026-10-09 12:40 ` [PATCH net-next v1 4/5] arm64: dts: s32n79-rdb: enable NETC IEP18 Claudiu Manoil
2026-10-09 12:40 ` [PATCH net-next v1 5/5] PCI: Create OF node for NXP ENETC pseudo-MAC functions Claudiu Manoil
2026-10-09 15:29   ` Bjorn Helgaas
2026-10-10 13:13 [PATCH net-next v1 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a DT overlay netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV2PR04MB117404685DA7A4291E5D41AF2969F2@GV2PR04MB11740.eurprd04.prod.outlook.com \
    --to=claudiu.manoil@nxp.com \
    --cc=S32@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=frank.li@oss.nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®