From: "shin, jacob" <jacob.shin@amd.com>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
clameter@sgi.com, ak@suse.de, "Langsdorf,
Mark" <mark.langsdorf@amd.com>
Subject: [PATCH] [1/1] slab: fix crash on __drain_alien_cahce() during CPU Hotplug
Date: Fri, 28 Apr 2006 10:54:37 -0500 [thread overview]
Message-ID: <B3870AD84389624BAF87A3C7B83149930293583F@SAUSEXMB2.amd.com> (raw)
transfer_objects should only be called when all of the cpus in the
node are online. CPU_DEAD notifier callback marks l3->shared to NULL.
Signed-off-by: Jacob Shin <jacob.shin@amd.com>
---
mm/slab.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux.orig/mm/slab.c 2006-04-26 21:19:25.000000000 -0500
+++ linux/mm/slab.c 2006-04-28 09:45:53.000000000 -0500
@@ -979,7 +979,8 @@ static void __drain_alien_cache(struct k
* That way we could avoid the overhead of putting the objects
* into the free lists and getting them back later.
*/
- transfer_objects(rl3->shared, ac, ac->limit);
+ if (rl3->shared)
+ transfer_objects(rl3->shared, ac, ac->limit);
free_block(cachep, ac->entry, ac->avail, node);
ac->avail = 0;
next reply other threads:[~2006-04-28 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 15:54 shin, jacob [this message]
2006-04-28 16:07 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B3870AD84389624BAF87A3C7B83149930293583F@SAUSEXMB2.amd.com \
--to=jacob.shin@amd.com \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®