* [PATCH] [1/1] slab: fix crash on __drain_alien_cahce() during CPU Hotplug
@ 2006-04-28 15:54 shin, jacob
2006-04-28 16:07 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: shin, jacob @ 2006-04-28 15:54 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, discuss, clameter, ak, Langsdorf, Mark
transfer_objects should only be called when all of the cpus in the
node are online. CPU_DEAD notifier callback marks l3->shared to NULL.
Signed-off-by: Jacob Shin <jacob.shin@amd.com>
---
mm/slab.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux.orig/mm/slab.c 2006-04-26 21:19:25.000000000 -0500
+++ linux/mm/slab.c 2006-04-28 09:45:53.000000000 -0500
@@ -979,7 +979,8 @@ static void __drain_alien_cache(struct k
* That way we could avoid the overhead of putting the objects
* into the free lists and getting them back later.
*/
- transfer_objects(rl3->shared, ac, ac->limit);
+ if (rl3->shared)
+ transfer_objects(rl3->shared, ac, ac->limit);
free_block(cachep, ac->entry, ac->avail, node);
ac->avail = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [1/1] slab: fix crash on __drain_alien_cahce() during CPU Hotplug
2006-04-28 15:54 [PATCH] [1/1] slab: fix crash on __drain_alien_cahce() during CPU Hotplug shin, jacob
@ 2006-04-28 16:07 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2006-04-28 16:07 UTC (permalink / raw)
To: shin, jacob; +Cc: torvalds, linux-kernel, discuss, ak, Langsdorf, Mark
On Fri, 28 Apr 2006, shin, jacob wrote:
> transfer_objects should only be called when all of the cpus in the
> node are online. CPU_DEAD notifier callback marks l3->shared to NULL.
Please drain the alien caches first then the shared caches and
then finally mark l3->shared NULL.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-28 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-28 15:54 [PATCH] [1/1] slab: fix crash on __drain_alien_cahce() during CPU Hotplug shin, jacob
2006-04-28 16:07 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®