Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register

[Richard Holden <aciddeath@gmail.com>]

On Nov 18, 2008, at 10:06 AM, Hannes Eder wrote:

> Do not ignore the return of 'device_create_file' in
> 'snd_card_register' and thereby fixing the following warnings:
>
> sound/core/init.c: In function 'snd_card_register':
> sound/core/init.c:640: warning: ignoring return value of
> 'device_create_file', declared with attribute warn_unused_result
> sound/core/init.c:641: warning: ignoring return value of
> 'device_create_file', declared with attribute warn_unused_result
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
>
> On Tue, Nov 18, 2008 at 11:14 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> The changes look good, but please run checkpatch.pl to your patch and
>> fix the coding style issues suggested there.
>
> I did not fix:
>
> "WARNING: line over 80 characters" as they a hardly longer than 80
> characters and there are lines longer than this in the same file.
>
> "ERROR: do not use assignment in if condition" as this pattern seems
> to be quite common.
>
> Comments? Should I fix them?

I would definitely fix the ERROR, I have seen messages from Linus with  
really bad comments about using that construct. Most maintainers also  
won't want to take a patch where checkpatch reports an error. Also  
fixing the ERROR should also fix the warning.

-Richard Holden