From: "Hannes Eder" <hannes@hanneseder.net>
To: "Takashi Iwai" <tiwai@suse.de>, "Richard Holden" <aciddeath@gmail.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register
Date: Tue, 18 Nov 2008 12:25:06 -0500 [thread overview]
Message-ID: <154e089b0811180925j7f35e87k22926d3c354b2c58@mail.gmail.com> (raw)
In-Reply-To: <s5h1vx9dkl7.wl%tiwai@suse.de>
Do not ignore the return of 'device_create_file' in
'snd_card_register' and thereby fixing the following warnings:
sound/core/init.c: In function 'snd_card_register':
sound/core/init.c:640: warning: ignoring return value of
'device_create_file', declared with attribute warn_unused_result
sound/core/init.c:641: warning: ignoring return value of
'device_create_file', declared with attribute warn_unused_result
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
All warnings and errors reported by checkpatch.pl fixed.
Thank you for your feedback.
sound/core/init.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/core/init.c b/sound/core/init.c
index af1e407..0d5520c 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -637,8 +637,12 @@ int snd_card_register(struct snd_card *card)
#endif
#ifndef CONFIG_SYSFS_DEPRECATED
if (card->card_dev) {
- device_create_file(card->card_dev, &card_id_attrs);
- device_create_file(card->card_dev, &card_number_attrs);
+ err = device_create_file(card->card_dev, &card_id_attrs);
+ if (err < 0)
+ return err;
+ err = device_create_file(card->card_dev, &card_number_attrs);
+ if (err < 0)
+ return err;
}
#endif
return 0;
next prev parent reply other threads:[~2008-11-18 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 15:59 Hannes Eder
2008-11-18 16:14 ` Takashi Iwai
2008-11-18 17:06 ` Hannes Eder
2008-11-18 17:12 ` Richard Holden
2008-11-18 17:12 ` Takashi Iwai
2008-11-18 17:25 ` Hannes Eder [this message]
2008-11-18 17:34 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e089b0811180925j7f35e87k22926d3c354b2c58@mail.gmail.com \
--to=hannes@hanneseder.net \
--cc=aciddeath@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®