* [PATCH 3/5] drivers/scsi: drop redundant memset
@ 2010-03-09 21:14 Julia Lawall
2010-03-10 1:05 ` jack wang
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-03-09 21:14 UTC (permalink / raw)
To: jack_wang, lindar_liu, James E.J. Bottomley, linux-scsi,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,e3,e4;
@@
- memset(e1,e2,e3);
memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/scsi/pm8001/pm8001_hwi.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
--- a/drivers/scsi/pm8001/pm8001_hwi.c
+++ b/drivers/scsi/pm8001/pm8001_hwi.c
@@ -4389,7 +4389,6 @@ pm8001_chip_fw_flash_update_req(struct p
return -ENOMEM;
}
}
- memset(buffer, 0, fw_control->len);
memcpy(buffer, fw_control->buffer, fw_control->len);
flash_update_info.sgl.addr = cpu_to_le64(phys_addr);
flash_update_info.sgl.im_len.len = cpu_to_le32(fw_control->len);
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH 3/5] drivers/scsi: drop redundant memset
2010-03-09 21:14 [PATCH 3/5] drivers/scsi: drop redundant memset Julia Lawall
@ 2010-03-10 1:05 ` jack wang
0 siblings, 0 replies; 2+ messages in thread
From: jack wang @ 2010-03-10 1:05 UTC (permalink / raw)
To: 'Julia Lawall',
lindar_liu, 'James E.J. Bottomley',
linux-scsi, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,e3,e4;
@@
- memset(e1,e2,e3);
memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/scsi/pm8001/pm8001_hwi.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/scsi/pm8001/pm8001_hwi.c
b/drivers/scsi/pm8001/pm8001_hwi.c
--- a/drivers/scsi/pm8001/pm8001_hwi.c
+++ b/drivers/scsi/pm8001/pm8001_hwi.c
@@ -4389,7 +4389,6 @@ pm8001_chip_fw_flash_update_req(struct p
return -ENOMEM;
}
}
- memset(buffer, 0, fw_control->len);
memcpy(buffer, fw_control->buffer, fw_control->len);
flash_update_info.sgl.addr = cpu_to_le64(phys_addr);
flash_update_info.sgl.im_len.len = cpu_to_le32(fw_control->len);
[Jack] Thanks Julia.
Acked-by: Jack Wang <jack_wang@usish.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-10 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-09 21:14 [PATCH 3/5] drivers/scsi: drop redundant memset Julia Lawall
2010-03-10 1:05 ` jack wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®