* gpio: pch/ml-ioh - leaking struct irq_chip_generic
@ 2012-07-03 19:30 Jean-François Dagenais
2012-07-04 0:18 ` Tomoya MORINAGA
0 siblings, 1 reply; 2+ messages in thread
From: Jean-François Dagenais @ 2012-07-03 19:30 UTC (permalink / raw)
To: Grant Likely, linus.walleij; +Cc: open list
Hi all,
Am I mistaken or these two drivers are missing a "irq_remove_generic_chip()"
then a "kfree" of the struct's memory in their xyz_remove() callbacks?
Kinda like "drivers/mfd/jz4740-adc.c" does?
/jfd
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gpio: pch/ml-ioh - leaking struct irq_chip_generic
2012-07-03 19:30 gpio: pch/ml-ioh - leaking struct irq_chip_generic Jean-François Dagenais
@ 2012-07-04 0:18 ` Tomoya MORINAGA
0 siblings, 0 replies; 2+ messages in thread
From: Tomoya MORINAGA @ 2012-07-04 0:18 UTC (permalink / raw)
To: Jean-François Dagenais, Grant Likely, linus.walleij; +Cc: open list
On Wed, Jul 4, 2012 at 4:30 AM, Jean-François Dagenais
<jeff.dagenais@gmail.com> wrote:
> Am I mistaken or these two drivers are missing a "irq_remove_generic_chip()"
> then a "kfree" of the struct's memory in their xyz_remove() callbacks?
>
> Kinda like "drivers/mfd/jz4740-adc.c" does?
>
Current upstreamed GPIO drivers(showed below) use irq_alloc_generic_chip().
drivers/gpio/gpio-ml-ioh.c
drivers/gpio/gpio-mxc.c
drivers/gpio/gpio-pl061.c
drivers/gpio/gpio-pch.c
drivers/gpio/gpio-mxs.c
drivers/gpio/gpio-sodavil
drivers/gpio/gpio-omap.c
However, no GPIO driver uses irq_remove_generic_chip().
I'm not familiar with these things. So I'm not sure whether
irq_remove_generic_chip is necessary or not.
Could maintainer or specialist of this tell us the information about it ?
thanks.
------
ROHM Co., Ltd.
Tomoya MORINAGA
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-04 0:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-03 19:30 gpio: pch/ml-ioh - leaking struct irq_chip_generic Jean-François Dagenais
2012-07-04 0:18 ` Tomoya MORINAGA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®