mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jason Dravet" <dravet@hotmail.com>
To: samuel.thibault@ens-lyon.org
Cc: 7eggert@gmx.de, adaplas@gmail.com, torvalds@osdl.org,
	akpm@osdl.org, davej@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vgacon: Workaround for resize bug in some chipsets
Date: Wed, 16 Nov 2005 19:37:00 -0600	[thread overview]
Message-ID: <BAY103-F28EE011A9ED5BBFB3F5D4FDF5F0@phx.gbl> (raw)
In-Reply-To: <20051116235216.GB7573@bouh.residence.ens-lyon.fr>

>From: Samuel Thibault <samuel.thibault@ens-lyon.org>
>To: Jason Dravet <dravet@hotmail.com>
>CC: 7eggert@gmx.de, adaplas@gmail.com, torvalds@osdl.org, 
>akpm@osdl.org,davej@redhat.com, linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] vgacon: Workaround for resize bug in some chipsets
>Date: Thu, 17 Nov 2005 00:52:16 +0100
>
>Hi,
>
>The following patch should correct the issue:
>
>When doublescan mode is in use, scanlines must be doubled.
>
>Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
>--- drivers/video/console/vgacon.c.orig	2005-11-17 00:40:02.000000000 +0100
>+++ drivers/video/console/vgacon.c	2005-11-17 00:42:27.000000000 +0100
>@@ -502,10 +502,16 @@
>  {
>  	unsigned long flags;
>  	unsigned int scanlines = height * c->vc_font.height;
>-	u8 scanlines_lo, r7, vsync_end, mode;
>+	u8 scanlines_lo, r7, vsync_end, mode, max_scan;
>
>  	spin_lock_irqsave(&vga_lock, flags);
>
>+	outb_p(VGA_CRTC_MAX_SCAN, vga_video_port_reg);
>+	max_scan = inb_p(vga_video_port_val);
>+
>+	if (max_scan & 0x80)
>+		scanlines <<= 1;
>+
>  	outb_p(VGA_CRTC_MODE, vga_video_port_reg);
>  	mode = inb_p(vga_video_port_val);
>

The patch does fix my problem.  Thank you Samuel.  I really appreciate the 
work you and Antonino have done on this issue.  I look forward to seeing 
this patch in the mainline.

Thanks again,
Jason Dravet



  reply	other threads:[~2005-11-17  1:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-16 17:58 Jason Dravet
2005-11-16 23:52 ` Samuel Thibault
2005-11-17  1:37   ` Jason Dravet [this message]
     [not found] <58DvZ-6en-1@gated-at.bofh.it>
2005-11-14  9:24 ` Bodo Eggert
2005-11-14 15:27   ` Jason Dravet
2005-11-14 16:32     ` Bodo Eggert
2005-11-16  0:05     ` Samuel Thibault
2005-11-16  1:50       ` Jason Dravet
2005-11-16  2:25         ` Samuel Thibault
  -- strict thread matches above, loose matches on Subject: below --
2005-11-14  3:46 Jason Dravet
     [not found] <58c2Z-8jG-23@gated-at.bofh.it>
2005-11-13 19:41 ` Bodo Eggert
2005-11-13 22:11   ` Antonino A. Daplas
2005-11-13 22:26     ` Mika Penttilä
2005-11-13 23:35       ` Antonino A. Daplas
2005-11-14  3:32         ` H. Peter Anvin
2005-11-13 22:24   ` Samuel Thibault
2005-11-12 22:20 Antonino A. Daplas
2005-11-13 10:23 ` Martin Mares
2005-11-13 11:06 ` Samuel Thibault
2005-11-13 14:33   ` Antonino A. Daplas
2005-11-13 22:25     ` Samuel Thibault
2005-11-13 23:37       ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAY103-F28EE011A9ED5BBFB3F5D4FDF5F0@phx.gbl \
    --to=dravet@hotmail.com \
    --cc=7eggert@gmx.de \
    --cc=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®