mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <harvested.in.lkml@7eggert.dyndns.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Dave Jones <davej@redhat.com>, Jason <dravet@hotmail.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vgacon: Workaround for resize bug in some chipsets
Date: Sun, 13 Nov 2005 20:41:04 +0100	[thread overview]
Message-ID: <E1EbNir-0006ky-DP@be1.lrz> (raw)
In-Reply-To: <58c2Z-8jG-23@gated-at.bofh.it>

Antonino A. Daplas <adaplas@gmail.com> wrote:

> +++ b/drivers/video/console/vgacon.c
> +#define VGA_FONTWIDTH       8   /* VGA does not support fontwidths != 8 */

This is not true, VGA cards do support fontwidth=9, but the ninth column
can only be blank or (optionally and only in the range of the IBM block
chars) copied from the eighth column, cloning the behaviour of the MDA
graphics card. If you disable this feature, you'll get 90x25 text resolution
within standard VGA timings.

BTW while looking at this file:

1) I see ORIG_VIDEO_EGA_BX (defined to (screen_info.orig_video_ega_bx)
being checked to be 0x10, but I don't find a place where the associated
variable is set to this value. Nor do I get the meaning of this variable
by reading it's name.

2) If the videomode is 7, the card is asumed not to be a VGA card.
VGA does support videomode 7, so this test is wrong. However, I don't
asume this mode to be used on normal systems as nobody complained.

I asume from the fragments I read that the correct fix would be to read
the Display Combination Code for VGA (detects additional CGA and MDA
adapters), then detect EGA (if it is, don't forget to check to check bit
3 of 0x487) and use the return code and finally to use the CRTC address
from the BIOS (The video mode may be set to 5 or 6 in order to make a
mouse driver work in Hercules graphics). In case of EGA, we'll
have to detect additional adapters manually. (Unfortunaly I threw away my
EGA-compatible monitor, so I don't know if I can test it.)

3) Having a text mode is tested by a blacklist of graphic modes. I don't
think this is good, but I've not yet read everything in this file.
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

       reply	other threads:[~2005-11-13 19:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <58c2Z-8jG-23@gated-at.bofh.it>
2005-11-13 19:41 ` Bodo Eggert [this message]
2005-11-13 22:11   ` Antonino A. Daplas
2005-11-13 22:26     ` Mika Penttilä
2005-11-13 23:35       ` Antonino A. Daplas
2005-11-14  3:32         ` H. Peter Anvin
2005-11-13 22:24   ` Samuel Thibault
2005-11-16 17:58 Jason Dravet
2005-11-16 23:52 ` Samuel Thibault
2005-11-17  1:37   ` Jason Dravet
     [not found] <58DvZ-6en-1@gated-at.bofh.it>
2005-11-14  9:24 ` Bodo Eggert
2005-11-14 15:27   ` Jason Dravet
2005-11-14 16:32     ` Bodo Eggert
2005-11-16  0:05     ` Samuel Thibault
2005-11-16  1:50       ` Jason Dravet
2005-11-16  2:25         ` Samuel Thibault
  -- strict thread matches above, loose matches on Subject: below --
2005-11-14  3:46 Jason Dravet
2005-11-12 22:20 Antonino A. Daplas
2005-11-13 10:23 ` Martin Mares
2005-11-13 11:06 ` Samuel Thibault
2005-11-13 14:33   ` Antonino A. Daplas
2005-11-13 22:25     ` Samuel Thibault
2005-11-13 23:37       ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1EbNir-0006ky-DP@be1.lrz \
    --to=harvested.in.lkml@7eggert.dyndns.org \
    --cc=7eggert@gmx.de \
    --cc=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=dravet@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®