From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
"Christophe Leroy, David Heidelberg" <david@ixit.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Takashi Iwai <tiwai@suse.de>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Paul Boddie <paul@boddie.org.uk>,
Olivier Louvignes <olivier@mgcrea.io>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 7/9] MIPS: Ingenic: Expand Kconfig for X1600, X2000, and X2600 SoCs
Date: Thu, 12 Nov 2026 16:48:13 +0100 [thread overview]
Message-ID: <BE31F647-6DDB-4B84-AD79-64BAEAB7AFC6@goldelico.com> (raw)
In-Reply-To: <26336f36c7ed09bcf64fcc2ae2d8aa1e0c1b7d23.camel@crapouillou.net>
> Am 12.11.2026 um 15:16 schrieb Paul Cercueil <paul@crapouillou.net>:
>
> Le jeudi 12 novembre 2026 à 09:10 +0100, H. Nikolaus Schaller a écrit :
>> Expand MACH_INGENIC_GENERIC to select all existing and newly added
>> machine variants (including JZ4750/55/60/75, X1500, X1600, X2000,
>> X2100, and X2600).
>>
>> Introduce individual Kconfig blocks for the following SoCs:
>> - MACH_X1600: Selects MIPS32_R2 and HIGHMEM.
>> - MACH_X2000 / MACH_X2600: Selects MIPS32_R5, SMP support, broadcast
>> clockevents, O32 FP64 support, and weak ordering optimizations.
>>
>> In parts developed by Reimu NotMoe <reimu@sudomaker.com>
>
> Co-developed-by? (+ his Sob)
I have to check what he really has developed. I think we did take this from
his github tree (https://github.com/Ingenic-community/linux/tree/v6.1.y) but
were never in contact with him. So I am not sure if we can get a SoB:.
>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/mips/ingenic/Kconfig | 38 ++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 38 insertions(+)
>>
>> diff --git a/arch/mips/ingenic/Kconfig b/arch/mips/ingenic/Kconfig
>> index f595b339a4b84..5d351b42bbc9b 100644
>> --- a/arch/mips/ingenic/Kconfig
>> +++ b/arch/mips/ingenic/Kconfig
>> @@ -5,10 +5,19 @@ config MACH_INGENIC_GENERIC
>> select MACH_INGENIC
>> select MACH_JZ4740
>> select MACH_JZ4725B
>> + select MACH_JZ4750
>> + select MACH_JZ4755
>> + select MACH_JZ4760
>> select MACH_JZ4770
>> + select MACH_JZ4775
>> select MACH_JZ4780
>> select MACH_X1000
>> + select MACH_X1500
>
> You select MACH_X1500 but there's no CONFIG_MACH_X1500 symbol. No entry in enum
> ingenic_machine_type either, or compatible string for it.
>
> Your patch didn't add a CONFIG_MACH_X2100 either.
Ok, that may be from taking the Reimu NotMoe patch without cross-checking.
Will be removed in V3.
>
>> + select MACH_X1600
>> select MACH_X1830
>> + select MACH_X2000
>> + select MACH_X2100
>> + select MACH_X2600
>>
>> choice
>> prompt "Machine type"
>> @@ -62,8 +71,10 @@ config MACH_JZ4770
>> config MACH_JZ4780
>> bool
>> select MIPS_CPU_SCACHE
>> + select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>> select SYS_HAS_CPU_MIPS32_R2
>> select SYS_SUPPORTS_HIGHMEM
>> + select SYS_SUPPORTS_SMP
>>
>> config MACH_X1000
>> bool
>> @@ -71,8 +82,35 @@ config MACH_X1000
>> select SYS_HAS_CPU_MIPS32_R2
>> select SYS_SUPPORTS_HIGHMEM
>>
>> +config MACH_X1600
>> + bool
>> + select SYS_HAS_CPU_MIPS32_R2
>> + select SYS_SUPPORTS_HIGHMEM
>> +
>> config MACH_X1830
>> bool
>> select MIPS_CPU_SCACHE
>> select SYS_HAS_CPU_MIPS32_R2
>> select SYS_SUPPORTS_HIGHMEM
>> +
>> +config MACH_X2000
>> + bool
>> + select MIPS_CPU_SCACHE
>> + select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>> + select SYS_HAS_CPU_MIPS32_R5
>> + select SYS_SUPPORTS_HIGHMEM
>> + select SYS_SUPPORTS_SMP
>> + select MIPS_O32_FP64_SUPPORT
>
> I know MIPS_O32_FP64_SUPPORT was supported on the JZ4770, and most likely on the
> JZ4760 too (the first one with a FPU AFAIK). So this could probably be moved to
> CONFIG_MACH_INGENIC.
That should be clearly checked. If I find a little time I can add it
or it can be done later.
BR and thanks,
Nikolaus
>
> Cheers,
> -Paul
>
>> + select WEAK_ORDERING
>> + select WEAK_REORDERING_BEYOND_LLSC
>> +
>> +config MACH_X2600
>> + bool
>> + select MIPS_CPU_SCACHE
>> + select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>> + select SYS_HAS_CPU_MIPS32_R5
>> + select SYS_SUPPORTS_HIGHMEM
>> + select SYS_SUPPORTS_SMP
>> + select MIPS_O32_FP64_SUPPORT
>> + select WEAK_ORDERING
>> + select WEAK_REORDERING_BEYOND_LLSC
next prev parent reply other threads:[~2026-11-12 15:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:10 [PATCH v2 0/9] MIPS: Ingenic: Add XBurst / XBurst II infrastructure and improve overall Ingenic SoC support H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 1/9] MIPS: Kconfig: Allow user selection of BUILTIN_DTB with description H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 2/9] MIPS: Ingenic: Configure CONFIG_BUILTIN_DTB=y for Ingenic based devices H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 3/9] MIPS: Ingenic: Do not force BUILTIN_DTB in Kconfig H. Nikolaus Schaller
2026-11-12 13:57 ` Paul Cercueil
2026-11-12 15:30 ` H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 4/9] MIPS: Ingenic: Add a new CPU_XBURST2 type H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 5/9] MIPS: Ingenic: Update Ingenic XBurst implementation IDs H. Nikolaus Schaller
2026-11-12 14:03 ` Paul Cercueil
2026-11-12 15:37 ` H. Nikolaus Schaller
2026-11-12 15:49 ` Paul Cercueil
2026-11-13 12:33 ` H. Nikolaus Schaller
2026-11-15 17:01 ` Olivier Louvignes
2026-11-16 0:00 ` Hunter Laux
2026-11-12 8:10 ` [PATCH v2 6/9] MIPS: generic: Add MACH_INGENIC type and compatible for X1600 and X2600 H. Nikolaus Schaller
2026-11-12 14:09 ` Paul Cercueil
2026-11-12 15:41 ` H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 7/9] MIPS: Ingenic: Expand Kconfig for X1600, X2000, and X2600 SoCs H. Nikolaus Schaller
2026-11-12 14:16 ` Paul Cercueil
2026-11-12 15:48 ` H. Nikolaus Schaller [this message]
2026-11-16 4:49 ` Hunter Laux
2026-11-12 8:10 ` [PATCH v2 8/9] MIPS: Ingenic: Expand Kconfig by MACH_JZ4730 H. Nikolaus Schaller
2026-11-12 8:10 ` [PATCH v2 9/9] MIPS: Ingenic: Add Platform makefile and load addresses for X1600, X2000, X2600 H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE31F647-6DDB-4B84-AD79-64BAEAB7AFC6@goldelico.com \
--to=hns@goldelico.com \
--cc=david@ixit.cz \
--cc=gregkh@linuxfoundation.org \
--cc=jmkrzyszt@gmail.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=olivier@mgcrea.io \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=tiwai@suse.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®