mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aditya Garg <aditya.garg@linux.dev>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Andre Eikmeyer <dev@deq.rocks>,
	arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org,
	brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org,
	Yossef Osman <Yossef.Osman@proton.me>
Subject: Re: [PATCH] wifi: brcmfmac: leave the AP 4-way handshake to the host on Apple chips
Date: Tue, 17 Nov 2026 23:19:18 +0530	[thread overview]
Message-ID: <BF5FB50E-063E-4EAA-A06D-ADC3670DEAE9@linux.dev> (raw)
In-Reply-To: <20261116203719.281605-3-arend.vanspriel@broadcom.com>



> On 17 Nov 2026, at 2:07 AM, Arend van Spriel <arend.vanspriel@broadcom.com> wrote:
> 
> On Wed, 4 Nov 2026 16:16:29 +0100, Andre Eikmeyer <dev@deq.rocks> wrote:
>> The Apple firmware for the BCM4364 and BCM4377 lists "idauth" in its
>> capabilities, so brcmfmac enables BRCMF_FEAT_FWAUTH and advertises
>> NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK. hostapd and wpa_supplicant
>> then pass the PSK to the driver and leave the AP side of the 4-way
>> handshake to the firmware. On the BCM4364 that handshake never
>> completes.
>> 
>> [...]
>> 
>> Clear BRCMF_FEAT_FWAUTH on the chips in Apple's T2 Macs, so the host
>> runs the handshake.
> 
> [...]
> 
>> ---
>> .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
> 
>> @@ -318,6 +318,20 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
>>                    BIT(BRCMF_FEAT_WOWL_GTK);
>>        }
>>    }
>> +    /* The Apple firmware for these chips lists "idauth", but in AP mode
>> +     * its authenticator never completes the 4-way handshake and the
>> +     * station is dropped after about 8 s. Leave the handshake to the host.
>> +     */
>> +    switch (drvr->bus_if->chip) {
>> +    case BRCM_CC_4355_CHIP_ID:
>> +    case BRCM_CC_4364_CHIP_ID:
>> +    case BRCM_CC_4377_CHIP_ID:
>> +        ifp->drvr->feat_flags &= ~BIT(BRCMF_FEAT_FWAUTH);
>> +        break;
>> +    default:
>> +        break;
>> +    }
>> +
>>    /* MBSS does not work for all chips */
>>    switch (drvr->bus_if->chip) {
> 
> The commit message and the test report only cover BCM4364 and BCM4377,
> but the code also clears FWAUTH for BCM4355. Where does that come from?
> Was it tested, and is BCM4355 found in T2 Macs? If not, please drop it
> or justify it.

4355 is also a Mac specific chip found in MacBookAir8,1 and 8,2. I'm actually surprised you forgot about that especially when there was a whole issue when Cypress named their chip firmware wrongly as 4355.

> 
> The chip ID check has the same problem as in the ARP/ND offload patch [1]:
> the issue is described as specific to the Apple firmware, but the quirk
> applies to every BCM4355, BCM4364 and BCM4377, and those users would lose
> offloaded AP PSK. Please restrict it as suggested there.
> 
> Note that BRCMF_FEAT_FWAUTH is required for NL80211_EXT_FEATURE_SAE_OFFLOAD_AP
> in brcmf_setup_wiphy(). Please mention in the commit message whether
> that is affected on these chips (i.e. whether the firmware offers "sae"
> at all) or confirm it is intentionally dropped too.
> 
> Have you looked at the actual root cause (e.g. missing/incorrect
> "idauth" related iovars such as setting the PMK or wsec_info for AP on
> this firmware)? If the offload is never usable on these firmwares, say
> so in the commit message with reference to the firmware version(s)
> checked.
> 
> [...]
> 
> Minor: please add the target tree to the subject (wifibot series_format
> warning).
> 
> [1] https://lore.kernel.org/all/20261104151620.70671-1-dev@deq.rocks/
> 
> Regards,
> Arend

  reply	other threads:[~2026-11-17 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:16 Andre Eikmeyer
2026-11-16 20:37 ` Arend van Spriel
2026-11-17 17:49   ` Aditya Garg [this message]
2026-11-17 19:44     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF5FB50E-063E-4EAA-A06D-ADC3670DEAE9@linux.dev \
    --to=aditya.garg@linux.dev \
    --cc=Yossef.Osman@proton.me \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dev@deq.rocks \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®