From: "Mikael Starvik" <mikael.starvik@axis.com>
To: <hugh@veritas.com>, <linux-kernel@vger.kernel.org>
Cc: "Mikael Starvik" <mikael.starvik@axis.com>
Subject: 2.6.9 PageAnon bug
Date: Wed, 20 Oct 2004 16:13:01 +0200 [thread overview]
Message-ID: <BFECAF9E178F144FAEF2BF4CE739C66818F59A@exmail1.se.axis.com> (raw)
There is at least one architecture supported by 2.6.9 that has no alignment
restrictions what so ever and no struct padding added by the compiler.
The patch named "rmaplock: PageAnon in mapping" in 2.6.9 doesn't work for
this architecture because it assumes that the address of a member in a
struct can't be odd.
One possible but ugly patch below. Another possible patch would be to move
i_data above i_bytes and i_sock. I would really like a cleaner patch but I
guess its a bad idea to add a new field to struct page?
Index: fs.h
===================================================================
RCS file: /usr/local/cvs/linux/os/lx25/include/linux/fs.h,v
retrieving revision 1.20
retrieving revision 1.21
diff -r1.20 -r1.21
449c449,453
< struct address_space i_data;
---
> /* The LSB in i_data below is used for the PAGE_MAPPING_ANON flag.
> * This assumes that the address of this member isn't odd which
> * is not true for all architectures. Force the compiler to align
it.
> */
> struct address_space i_data __attribute__ ((aligned(4)));
Anyone who knows about similar usage of bit 0 and/or 1 in pointers
anywhere?
/Mikael
PS. The architecture I'm referring to is CRIS but there may be more with the
same sloppyness regarding alignment. DS
next reply other threads:[~2004-10-20 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 14:13 Mikael Starvik [this message]
2004-10-20 15:01 ` Hugh Dickins
[not found] <BFECAF9E178F144FAEF2BF4CE739C66801960A13@exmail1.se.axis.com>
2004-10-20 15:21 ` Mikael Starvik
2004-10-20 18:15 ` Hugh Dickins
[not found] <BFECAF9E178F144FAEF2BF4CE739C66818F59A@exmail1.se.axis.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0410201542140.9192-100000@localhost.localdomain.suse.lists.linux.kernel>
2004-10-20 19:27 ` Andi Kleen
2004-10-20 19:54 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BFECAF9E178F144FAEF2BF4CE739C66818F59A@exmail1.se.axis.com \
--to=mikael.starvik@axis.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®