From: "Mikael Starvik" <mikael.starvik@axis.com>
To: "'Hugh Dickins'" <hugh@veritas.com>,
"Mikael Starvik" <mikael.starvik@axis.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: 2.6.9 PageAnon bug
Date: Wed, 20 Oct 2004 17:21:44 +0200 [thread overview]
Message-ID: <BFECAF9E178F144FAEF2BF4CE739C66818F59B@exmail1.se.axis.com> (raw)
In-Reply-To: <BFECAF9E178F144FAEF2BF4CE739C66801960A13@exmail1.se.axis.com>
>Ah, sorry for messing CRIS up, I was unaware of that.
Well, it's kind of odd nowadays to have the freedom of arbitrary alignment.
>I don't think that's ugly, and the comment is good.
>It only actually needs "aligned(2)", would that be better?
Yes, aligned(2) is enough.
>But what does "aligned(2)" or "aligned(4)" do on 64-bit machines -
>any danger of it aligning stupidly? I think not, but know little.
Same here, we need input from the 64-bit world (or make it aligned(8)).
>>Another possible patch would be to move i_data above i_bytes and i_sock.
>Really? Precarious, I think you'd still need to insist on alignment.
I agree that there may be compilers out there that actually pads the
structure to make the members unaligned. So you are correct, aligned()
should be used to be safe (until memory allocation routines start to return
unaligned addresses).
Will you send this upstream to Andrew?
Thanks for the quick response!
/Mikael
next parent reply other threads:[~2004-10-20 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BFECAF9E178F144FAEF2BF4CE739C66801960A13@exmail1.se.axis.com>
2004-10-20 15:21 ` Mikael Starvik [this message]
2004-10-20 18:15 ` Hugh Dickins
[not found] <BFECAF9E178F144FAEF2BF4CE739C66818F59A@exmail1.se.axis.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0410201542140.9192-100000@localhost.localdomain.suse.lists.linux.kernel>
2004-10-20 19:27 ` Andi Kleen
2004-10-20 19:54 ` Hugh Dickins
2004-10-20 14:13 Mikael Starvik
2004-10-20 15:01 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BFECAF9E178F144FAEF2BF4CE739C66818F59B@exmail1.se.axis.com \
--to=mikael.starvik@axis.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®