Re: [PATCH] blackfin: Makefile: Add -D__linux__ flag for KBUILD_CFLAGS

[Chen Gang <xili_gchen_5257@hotmail.com>]

On 4/5/15 05:17, Richard Weinberger wrote:
> Am 04.04.2015 um 23:13 schrieb Chen Gang:
>> Is what I have done above correct? Or can we treate it as gcc's issue?
> 
> At least ask gcc folks about that before you add a random hack to the kernel.
> 

For the latest compiler, it should contents -D__linux__, and what I have
done for building gcc/binutils is the common way, so I guess binutils or
gcc need improvement (I shall try to fix it within this month).

But, I am not quite sure whether the old version bfin compilers also
supports -D__linux__ (comparing some of the old compilers of the other
archs, I guess not). Are you sure the old version bfin compilers are OK?


BTW, for the latest bfin compiler from upstream, it contents another
issues which I bypassed now. I shall try to fix them within this month
(try to send all fix patches v1 within 2015-04-20).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed