* [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS
@ 2022-09-15 23:38 Prabhakar
2022-09-18 9:32 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Prabhakar @ 2022-09-15 23:38 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Russell King, linux-arm-kernel,
linux-renesas-soc
Cc: linux-kernel, Prabhakar, Biju Das, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Don't automatically select the SOC_BUS config option as we already have
automatically selected it as part of the SOC_RENESAS config option [0]
as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
[0] drivers/soc/renesas/Kconfig
[1] drivers/soc/renesas/renesas-soc.c
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm/mach-shmobile/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index 50909c4b95b2..37f862f13c8d 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
select GPIOLIB
select NO_IOPORT_MAP
select PINCTRL
- select SOC_BUS
select ZONE_DMA if ARM_LPAE
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS
2022-09-15 23:38 [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS Prabhakar
@ 2022-09-18 9:32 ` Geert Uytterhoeven
2022-09-19 9:45 ` Lad, Prabhakar
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-18 9:32 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Russell King, linux-arm-kernel, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Prabhakar,
On Fri, Sep 16, 2022 at 1:39 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Don't automatically select the SOC_BUS config option as we already have
> automatically selected it as part of the SOC_RENESAS config option [0]
> as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
>
> [0] drivers/soc/renesas/Kconfig
> [1] drivers/soc/renesas/renesas-soc.c
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.1.
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
> select GPIOLIB
> select NO_IOPORT_MAP
> select PINCTRL
> - select SOC_BUS
> select ZONE_DMA if ARM_LPAE
Nice catch!
I guess it would make sense to move the GPIOLIB and PINCTRL selects
to drivers/soc/renesas/Kconfig, too, as they are needed for all
(arm32/arm64/riscv) Renesas SoCs?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS
2022-09-18 9:32 ` Geert Uytterhoeven
@ 2022-09-19 9:45 ` Lad, Prabhakar
2022-09-19 9:49 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Lad, Prabhakar @ 2022-09-19 9:45 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Russell King, linux-arm-kernel, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Geert,
Thank you for the review.
On Sun, Sep 18, 2022 at 10:32 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, Sep 16, 2022 at 1:39 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Don't automatically select the SOC_BUS config option as we already have
> > automatically selected it as part of the SOC_RENESAS config option [0]
> > as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
> >
> > [0] drivers/soc/renesas/Kconfig
> > [1] drivers/soc/renesas/renesas-soc.c
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.1.
>
> > --- a/arch/arm/mach-shmobile/Kconfig
> > +++ b/arch/arm/mach-shmobile/Kconfig
> > @@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
> > select GPIOLIB
> > select NO_IOPORT_MAP
> > select PINCTRL
> > - select SOC_BUS
> > select ZONE_DMA if ARM_LPAE
>
> Nice catch!
> I guess it would make sense to move the GPIOLIB and PINCTRL selects
> to drivers/soc/renesas/Kconfig, too, as they are needed for all
> (arm32/arm64/riscv) Renesas SoCs?
>
Agreed, shall I move them under SOC_RENESAS?
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS
2022-09-19 9:45 ` Lad, Prabhakar
@ 2022-09-19 9:49 ` Geert Uytterhoeven
2022-09-19 10:47 ` Lad, Prabhakar
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-19 9:49 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: Magnus Damm, Russell King, linux-arm-kernel, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Prabhakar,
On Mon, Sep 19, 2022 at 11:46 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Sun, Sep 18, 2022 at 10:32 AM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Fri, Sep 16, 2022 at 1:39 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Don't automatically select the SOC_BUS config option as we already have
> > > automatically selected it as part of the SOC_RENESAS config option [0]
> > > as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
> > >
> > > [0] drivers/soc/renesas/Kconfig
> > > [1] drivers/soc/renesas/renesas-soc.c
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v6.1.
> >
> > > --- a/arch/arm/mach-shmobile/Kconfig
> > > +++ b/arch/arm/mach-shmobile/Kconfig
> > > @@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
> > > select GPIOLIB
> > > select NO_IOPORT_MAP
> > > select PINCTRL
> > > - select SOC_BUS
> > > select ZONE_DMA if ARM_LPAE
> >
> > Nice catch!
> > I guess it would make sense to move the GPIOLIB and PINCTRL selects
> > to drivers/soc/renesas/Kconfig, too, as they are needed for all
> > (arm32/arm64/riscv) Renesas SoCs?
> >
> Agreed, shall I move them under SOC_RENESAS?
That's the place I had in mind ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS
2022-09-19 9:49 ` Geert Uytterhoeven
@ 2022-09-19 10:47 ` Lad, Prabhakar
0 siblings, 0 replies; 5+ messages in thread
From: Lad, Prabhakar @ 2022-09-19 10:47 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Russell King, linux-arm-kernel, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Geert,
On Mon, Sep 19, 2022 at 10:49 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, Sep 19, 2022 at 11:46 AM Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
> > On Sun, Sep 18, 2022 at 10:32 AM Geert Uytterhoeven
> > <geert@linux-m68k.org> wrote:
> > > On Fri, Sep 16, 2022 at 1:39 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > >
> > > > Don't automatically select the SOC_BUS config option as we already have
> > > > automatically selected it as part of the SOC_RENESAS config option [0]
> > > > as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
> > > >
> > > > [0] drivers/soc/renesas/Kconfig
> > > > [1] drivers/soc/renesas/renesas-soc.c
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > i.e. will queue in renesas-devel for v6.1.
> > >
> > > > --- a/arch/arm/mach-shmobile/Kconfig
> > > > +++ b/arch/arm/mach-shmobile/Kconfig
> > > > @@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
> > > > select GPIOLIB
> > > > select NO_IOPORT_MAP
> > > > select PINCTRL
> > > > - select SOC_BUS
> > > > select ZONE_DMA if ARM_LPAE
> > >
> > > Nice catch!
> > > I guess it would make sense to move the GPIOLIB and PINCTRL selects
> > > to drivers/soc/renesas/Kconfig, too, as they are needed for all
> > > (arm32/arm64/riscv) Renesas SoCs?
> > >
> > Agreed, shall I move them under SOC_RENESAS?
>
> That's the place I had in mind ;-)
>
Done, I have sent it out.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-19 10:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 23:38 [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS Prabhakar
2022-09-18 9:32 ` Geert Uytterhoeven
2022-09-19 9:45 ` Lad, Prabhakar
2022-09-19 9:49 ` Geert Uytterhoeven
2022-09-19 10:47 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®