From: Bingfang Guo <bfguo@icloud.com>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: bingfangguo@tencent.com, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <david@fromorbit.com>, Qi Zheng <qi.zheng@linux.dev>,
Kairui Song <kasong@tencent.com>, Barry Song <baohua@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] memcg: manipulate memcg private ID references by ID
Date: Sun, 20 Sep 2026 18:07:45 +0800 [thread overview]
Message-ID: <CA3A67DE-DF83-4B0E-81A2-AEDE93FF5F78@icloud.com> (raw)
In-Reply-To: <aq2dkhBuFktQYvTB@linux.dev>
On Fri, Sep 18, 2026 at 01:24:01PM -0700, Shakeel Butt wrote:
> On Sat, Sep 19, 2026 at 02:46:52AM +0800, Bingfang Guo wrote:
>> Thanks for pointing out this.
>>
>> Agreed. Both two callers are already holding the rcu lock so
>> taking the lock here is unnecessary. So I will drop the
>> rcu_read_lock() and use that in the next version!
>>
>> My concern is that: mem_cgroup_private_id_put() looks like a
>> universal put function, requiring rcu held (which is true today)
>> is not that obvious to the users. So I think adding a short kdoc
>> comment to make it clear later might be a good idea.
>
> This function is internal to memcg code, so whoever is going to call it better
> know to call it with rcu held because of lockdep assert. No need to have a
> comment.
Okay, I'll keep that in mind!
next prev parent reply other threads:[~2026-09-20 10:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 9:18 [PATCH 0/4] memcg: move memcgid refcount to objcg to unpin dying memcgs Bingfang Guo via B4 Relay
2026-09-18 9:18 ` [PATCH 1/4] memcg: keep swap charging under RCU protection Bingfang Guo via B4 Relay
2026-09-18 12:07 ` Muchun Song
2026-09-18 16:46 ` Shakeel Butt
2026-09-18 17:51 ` Bingfang Guo
2026-09-18 9:18 ` [PATCH 2/4] memcg: base swap charge accounting on memcgid root status Bingfang Guo via B4 Relay
2026-09-19 2:56 ` Muchun Song
2026-09-18 9:18 ` [PATCH 3/4] memcg: manipulate memcg private ID references by ID Bingfang Guo via B4 Relay
2026-09-18 18:14 ` Shakeel Butt
2026-09-18 18:46 ` Bingfang Guo
2026-09-18 20:24 ` Shakeel Butt
2026-09-20 10:07 ` Bingfang Guo [this message]
2026-09-19 3:06 ` Muchun Song
2026-09-18 9:18 ` [PATCH 4/4] memcg: move memcg private ID refcount to objcg Bingfang Guo via B4 Relay
2026-09-18 18:19 ` Shakeel Butt
2026-09-18 19:14 ` Bingfang Guo
2026-09-19 3:32 ` Muchun Song
2026-09-20 10:08 ` Bingfang Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA3A67DE-DF83-4B0E-81A2-AEDE93FF5F78@icloud.com \
--to=bfguo@icloud.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=bingfangguo@tencent.com \
--cc=cgroups@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®