From: Oleg Drokin <oleg.drokin@intel.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<lustre-devel@lists.lustre.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: lustre: llite: don't clean in_data again
Date: Sat, 20 Aug 2016 23:38:49 -0400 [thread overview]
Message-ID: <CA538835-AB7D-46CC-8C01-02CE2526D76F@intel.com> (raw)
In-Reply-To: <1471747477-31654-1-git-send-email-shawn.lin@rock-chips.com>
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote:
> We have got a zero buffer for in_data as we use
> kzalloc here. So let's remove it anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/staging/lustre/lustre/llite/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index 50938bd..ec6b7ce 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd)
> if (!in_data)
> return NULL;
>
> - memset(in_data, 0, sizeof(*in_data));
> in_data->iocd_size = size;
> in_data->iocd_cb = cb;
> in_data->iocd_count = count;
> --
> 2.3.7
>
prev parent reply other threads:[~2016-08-21 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 2:44 Shawn Lin
2016-08-21 3:38 ` Oleg Drokin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA538835-AB7D-46CC-8C01-02CE2526D76F@intel.com \
--to=oleg.drokin@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®