* [PATCH] staging: lustre: llite: don't clean in_data again
@ 2016-08-21 2:44 Shawn Lin
2016-08-21 3:38 ` Oleg Drokin
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Lin @ 2016-08-21 2:44 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, James Simmons
Cc: Greg Kroah-Hartman, lustre-devel, devel, linux-kernel, Shawn Lin
We have got a zero buffer for in_data as we use
kzalloc here. So let's remove it anyway.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/staging/lustre/lustre/llite/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
index 50938bd..ec6b7ce 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd)
if (!in_data)
return NULL;
- memset(in_data, 0, sizeof(*in_data));
in_data->iocd_size = size;
in_data->iocd_cb = cb;
in_data->iocd_count = count;
--
2.3.7
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: llite: don't clean in_data again
2016-08-21 2:44 [PATCH] staging: lustre: llite: don't clean in_data again Shawn Lin
@ 2016-08-21 3:38 ` Oleg Drokin
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Drokin @ 2016-08-21 3:38 UTC (permalink / raw)
To: Shawn Lin
Cc: Andreas Dilger, James Simmons, Greg Kroah-Hartman, lustre-devel,
devel, linux-kernel
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote:
> We have got a zero buffer for in_data as we use
> kzalloc here. So let's remove it anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/staging/lustre/lustre/llite/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index 50938bd..ec6b7ce 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd)
> if (!in_data)
> return NULL;
>
> - memset(in_data, 0, sizeof(*in_data));
> in_data->iocd_size = size;
> in_data->iocd_cb = cb;
> in_data->iocd_count = count;
> --
> 2.3.7
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-21 3:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-21 2:44 [PATCH] staging: lustre: llite: don't clean in_data again Shawn Lin
2016-08-21 3:38 ` Oleg Drokin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®