From: Marco Crivellari <marco.crivellari@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] RAS/CEC: replace use of system_wq with system_percpu_wq
Date: Thu, 6 Nov 2025 10:17:18 +0100 [thread overview]
Message-ID: <CAAofZF4Sdk0REJFearcrB5_MLLQZWaNpecUPV0+BOiNcvmTaWA@mail.gmail.com> (raw)
In-Reply-To: <20251105210800.GCaQu8sKCjZ9Xcq8-n@fat_crate.local>
On Wed, Nov 5, 2025 at 10:08 PM Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Nov 05, 2025 at 05:55:49PM +0100, Marco Crivellari wrote:
> > The code is using system_wq, this is the per-cpu workqueue. This change will
> > only replace system_wq with system_percpu_wq. So the behavior is the same as
> > before.
>
> What does that mean?
>
> We're going away from system_wq in favor or system_percpu_wq? Or?
>
It's just a "rename" from system_wq to system_percpu_wq.
system_percpu_wq is a per-cpu workqueue, exactly as system_wq.
But in a few release cycles system_wq will be removed from the code.
If you want to have more details, you can read this discussion:
https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
> It is not clear to me what the issue is what the new correct way should be...
There is no issue, except that system_wq will be removed. In order to
achieve the same result as system_wq, the correct workqueue to use
is system_percpu_wq.
As you can see from:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
system_percpu_wq is defined as a per-cpu workqueue, exactly as system_wq.
Thanks!
--
Marco Crivellari
L3 Support Engineer, Technology & Product
next prev parent reply other threads:[~2025-11-06 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 16:08 Marco Crivellari
2025-11-05 16:29 ` Borislav Petkov
2025-11-05 16:55 ` Marco Crivellari
2025-11-05 21:08 ` Borislav Petkov
2025-11-06 9:17 ` Marco Crivellari [this message]
2025-11-06 10:49 ` Borislav Petkov
2025-11-06 11:03 ` Marco Crivellari
2025-11-06 11:11 ` Borislav Petkov
2025-11-06 11:16 ` Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAofZF4Sdk0REJFearcrB5_MLLQZWaNpecUPV0+BOiNcvmTaWA@mail.gmail.com \
--to=marco.crivellari@suse.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®