mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marco Crivellari <marco.crivellari@suse.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	 kernel@collabora.com, Tejun Heo <tj@kernel.org>,
	 Lai Jiangshan <jiangshanlai@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	 Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Michal Hocko <mhocko@suse.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: synopsys: hdmirx: replace use of system_unbound_wq with system_dfl_wq
Date: Tue, 4 Nov 2025 17:44:14 +0100	[thread overview]
Message-ID: <CAAofZF7k7LDxGoXENBtrpP-xokGoCJCqouGX-qumGTPwipAwVw@mail.gmail.com> (raw)
In-Reply-To: <5ce483e5-7384-4d63-8dac-8050c2bd5930@collabora.com>

Hi,

On Tue, Nov 4, 2025 at 1:46 PM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> Hi,
>[...]
> Took me a minute to find what "dfl" stands for. Would be great if the
> name was self-explanatory as system_default_wq. Even then, not clear to
> me what's the point of this remaining, the system_dfl_wq naming feels
> very obscure compared to the explicit system_unbound_wq.
>
> Could you please explain the logic behind the new naming? Doesn't it
> create more confusion than remove?

Yes, dfl it is just the abbreviation of default.

The reason is to suggest the use of the unbound workqueue
instead of the per-cpu, unless this is really needed, of course.

There are parts of the code who just used system_wq thinking it was the
unbound workqueue (the "general" wq to use), so to make explicit the
"default" is the unbound (system_dfl_wq) I think it is appropriate.

I saw this myself also in this conversion round: there are maintainers
who are asking
to change the wq they were using from system_wq to system_dfl_wq.

Let me share also where the API change (and other stuff) have been discussed:

https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/

On Tue, Nov 4, 2025 at 1:46 PM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
> AFAICS, right now system_dfl_wq duplicates system_unbound_wq. Suppose,
> instead, the default wq could alias the system_unbound_wq.

The idea was just give 1 choice, so remove system_unbound_wq (and
system_wq) in future.
Personally I don't have a strong opinion, but I think it's easier to
have just 1 unbound wq, and 1
per-cpu wq.

But if Tejun has other suggestions, based on your observation, I'm fine with it!

Thanks!

--

Marco Crivellari

L3 Support Engineer, Technology & Product

  reply	other threads:[~2025-11-04 16:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 10:20 Marco Crivellari
2025-11-04 12:45 ` Dmitry Osipenko
2025-11-04 16:44   ` Marco Crivellari [this message]
2026-02-04 11:49 ` Marco Crivellari
2026-02-09 20:46   ` Dmitry Osipenko
2026-02-09 21:18     ` Dmitry Osipenko
2026-02-10 14:36       ` Marco Crivellari
2026-02-11 16:45         ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAofZF7k7LDxGoXENBtrpP-xokGoCJCqouGX-qumGTPwipAwVw@mail.gmail.com \
    --to=marco.crivellari@suse.com \
    --cc=bigeasy@linutronix.de \
    --cc=dmitry.osipenko@collabora.com \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mhocko@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®