mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Documentation: Add detailed explanation for 'N' taint flag
@ 2024-07-17 20:35 Benjamin Poirier
  2024-07-17 21:11 ` Luis Chamberlain
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Benjamin Poirier @ 2024-07-17 20:35 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Thorsten Blum, Luis Chamberlain, David Gow, Shuah Khan,
	Brendan Higgins, linux-doc, linux-kernel

Every taint flag has an entry in the "More detailed explanation" section
except for the 'N' flag. That omission was probably just an oversight so
add an entry for that flag.

Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
---
 Documentation/admin-guide/tainted-kernels.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/admin-guide/tainted-kernels.rst b/Documentation/admin-guide/tainted-kernels.rst
index f92551539e8a..700aa72eecb1 100644
--- a/Documentation/admin-guide/tainted-kernels.rst
+++ b/Documentation/admin-guide/tainted-kernels.rst
@@ -182,3 +182,5 @@ More detailed explanation for tainting
      produce extremely unusual kernel structure layouts (even performance
      pathological ones), which is important to know when debugging. Set at
      build time.
+
+ 18) ``N`` if an in-kernel test, such as a KUnit test, has been run.
-- 
2.45.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: Add detailed explanation for 'N' taint flag
  2024-07-17 20:35 [PATCH] Documentation: Add detailed explanation for 'N' taint flag Benjamin Poirier
@ 2024-07-17 21:11 ` Luis Chamberlain
  2024-07-18  5:55 ` David Gow
  2024-07-29 21:45 ` Jonathan Corbet
  2 siblings, 0 replies; 4+ messages in thread
From: Luis Chamberlain @ 2024-07-17 21:11 UTC (permalink / raw)
  To: Benjamin Poirier
  Cc: Jonathan Corbet, Thorsten Blum, David Gow, Shuah Khan,
	Brendan Higgins, linux-doc, linux-kernel

On Wed, Jul 17, 2024 at 04:35:21PM -0400, Benjamin Poirier wrote:
> Every taint flag has an entry in the "More detailed explanation" section
> except for the 'N' flag. That omission was probably just an oversight so
> add an entry for that flag.
> 
> Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
> ---

Acked-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: Add detailed explanation for 'N' taint flag
  2024-07-17 20:35 [PATCH] Documentation: Add detailed explanation for 'N' taint flag Benjamin Poirier
  2024-07-17 21:11 ` Luis Chamberlain
@ 2024-07-18  5:55 ` David Gow
  2024-07-29 21:45 ` Jonathan Corbet
  2 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2024-07-18  5:55 UTC (permalink / raw)
  To: Benjamin Poirier
  Cc: Jonathan Corbet, Thorsten Blum, Luis Chamberlain, Shuah Khan,
	Brendan Higgins, linux-doc, linux-kernel

On Thu, 18 Jul 2024 at 04:36, Benjamin Poirier <bpoirier@nvidia.com> wrote:
>
> Every taint flag has an entry in the "More detailed explanation" section
> except for the 'N' flag. That omission was probably just an oversight so
> add an entry for that flag.
>
> Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
> ---

Nice catch, thanks!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David


>  Documentation/admin-guide/tainted-kernels.rst | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/admin-guide/tainted-kernels.rst b/Documentation/admin-guide/tainted-kernels.rst
> index f92551539e8a..700aa72eecb1 100644
> --- a/Documentation/admin-guide/tainted-kernels.rst
> +++ b/Documentation/admin-guide/tainted-kernels.rst
> @@ -182,3 +182,5 @@ More detailed explanation for tainting
>       produce extremely unusual kernel structure layouts (even performance
>       pathological ones), which is important to know when debugging. Set at
>       build time.
> +
> + 18) ``N`` if an in-kernel test, such as a KUnit test, has been run.
> --
> 2.45.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: Add detailed explanation for 'N' taint flag
  2024-07-17 20:35 [PATCH] Documentation: Add detailed explanation for 'N' taint flag Benjamin Poirier
  2024-07-17 21:11 ` Luis Chamberlain
  2024-07-18  5:55 ` David Gow
@ 2024-07-29 21:45 ` Jonathan Corbet
  2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2024-07-29 21:45 UTC (permalink / raw)
  To: Benjamin Poirier
  Cc: Thorsten Blum, Luis Chamberlain, David Gow, Shuah Khan,
	Brendan Higgins, linux-doc, linux-kernel

Benjamin Poirier <bpoirier@nvidia.com> writes:

> Every taint flag has an entry in the "More detailed explanation" section
> except for the 'N' flag. That omission was probably just an oversight so
> add an entry for that flag.
>
> Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
> ---
>  Documentation/admin-guide/tainted-kernels.rst | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/admin-guide/tainted-kernels.rst b/Documentation/admin-guide/tainted-kernels.rst
> index f92551539e8a..700aa72eecb1 100644
> --- a/Documentation/admin-guide/tainted-kernels.rst
> +++ b/Documentation/admin-guide/tainted-kernels.rst
> @@ -182,3 +182,5 @@ More detailed explanation for tainting
>       produce extremely unusual kernel structure layouts (even performance
>       pathological ones), which is important to know when debugging. Set at
>       build time.
> +
> + 18) ``N`` if an in-kernel test, such as a KUnit test, has been run.

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-07-29 21:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-17 20:35 [PATCH] Documentation: Add detailed explanation for 'N' taint flag Benjamin Poirier
2024-07-17 21:11 ` Luis Chamberlain
2024-07-18  5:55 ` David Gow
2024-07-29 21:45 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®